Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup of the Sankey function #469

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Minor cleanup of the Sankey function #469

merged 3 commits into from
Dec 17, 2020

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Dec 17, 2020 •
edited
Loading

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR makes two minor modifications after merging #464 (which added an own plotting docs page):

  • add the sankey function to the plotting docs page
  • pass the IamDataFrame to the internal function, use df._data instead of casting to wide format via timeseries()
  • check that all columns are unique (anticipating use with the extra-columns feature)
  • move the line in the release-notes of Sankey plot #466 to the correct location (my bad for having missed this during review)

@danielhuppmann danielhuppmann self-assigned this Dec 17, 2020
mabudz
mabudz approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@mabudz mabudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright :)

@danielhuppmann danielhuppmann merged commit e76c91d into IAMconsortium:master Dec 17, 2020
@danielhuppmann danielhuppmann deleted the plotting/sankey-cleanup branch December 17, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabudz mabudz mabudz approved these changes

Assignees

@danielhuppmann danielhuppmann

Labels
plotting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhuppmann @mabudz