-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sankey plot #466
Sankey plot #466
Conversation
there was an update of the sphinxcontrib-bibtex package and a change of the WorldBank data used in the pandas_datarader test, which currently causes unit tests to fail - don't worry about that for now |
Alright. I just address the recommendations of picky Mr.Sticklers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mabudz for this nice addition! a few suggestions to clean up the implementation... Also, I resolved all issues by stickler that you have implemented, but there are still a few stickler requests...
I also just realized that you need to add |
Ah, I forgot to add the plotly dependencies. Should not do this while sitting on the airport :))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion for a formatting clean-up inline, and please add to the release notes - then good to go! As discussed, we'll tackle an example for the plotting gallery and tests during/after the holidays...
Merging and tackling the tests in a next iteration - thanks @mabudz! |
Please confirm that this PR has done the following:
Tests AddedDescription of PR
This PR introduces a function sankey() to create a basic Sankey diagram using plotly [https://plotly.com/python/sankey-diagram/]. This figure can be further modified (e.g.
fig.update_traces()
) or used (e.g.fig.write_html()
) by the user [https://plotly.com/python/graph-objects/]The function uses a mapping dictionary {'variable1': ('source1', 'target1'), ...} to specify the source and the target node for the considered variables.
Currently only one region and one year can be plotted.