install: reject Snow Leopard and Leopard installations. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
previously requested changes
Jan 6, 2019
| @@ -170,7 +170,6 @@ def chgrp?(path) | |||
| end | |||
|
|
|||
| # Invalidate sudo timestamp before exiting (if it wasn't active before). | |||
| Kernel.system "/usr/bin/sudo -n -v 2>/dev/null" unless macos_version < "10.7" | |||
There was a problem hiding this comment.
This is still needed, only remove the unless.
There was a problem hiding this comment.
@reitermarkus Thanks!
These will be deprecated in future so let's stop getting any new installs now. See some related deprecations in Homebrew/brew#5477.
|
How much, if any, does @mistydemeo know about this? She may want to add support for these OS X versions to Tigerbrew (though that might necessitate a rename…) |
|
@RandomDSdevel I haven't talked with @mistydemeo about it yet. I'm unsure to what extent those versions work or don't currently. While we're on the topic 2.0.0 won't support any versions below Mavericks (10.9). |
|
Right, OK; this doesn't actually affect me, but I was still curious anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be deprecated in future so let's stop getting any new installs now.
See some related deprecations in Homebrew/brew#5477.