Update deprecations #5477
Update deprecations #5477
Conversation
|
Do not merge until the next tag will be 1.9.0. |
| # Uninstall old brew-cask if it's still around; we just use the tap now. | ||
| if cmd == "cask" && (HOMEBREW_CELLAR/"brew-cask").exist? | ||
| system(HOMEBREW_BREW_FILE, "uninstall", "--force", "brew-cask") | ||
| end | ||
|
|
||
| if ENV["HOMEBREW_BUILD_FROM_SOURCE"] | ||
| odeprecated("HOMEBREW_BUILD_FROM_SOURCE", "--build-from-source") | ||
| end |
There was a problem hiding this comment.
Please, please tell me that this variable and cmdline flag are not going away.
There was a problem hiding this comment.
@chdiza @RandomDSdevel Yes, the HOMEBREW_BUILD_FROM_SOURCE environment variable is going away. It tells people to not file issues they encounter but they keep doing so regardless. This is a waste of time for the Homebrew maintainers.
Homebrew is not a from-source package manager any more. #5491 means that building from source is going to generate identical output to bottles. Homebrew/homebrew-core#31510 means there will be no reason to build from source when using the supported Homebrew installation location. --build-from-source is sticking around for people to be able to reproduce issues by building specific packages from source on request.
There was a problem hiding this comment.
@MikeMcQuaid I apologize that people report issues about source builds. I did that once, before I understood that they weren't officially supported. However, building from source is an extremely valuable feature to me. Allowing users to set HOMEBREW_BUILD_FROM_SOURCE feels right. Personally, I love digging through the source code of installed programs and libraries, and seeing their make invocations go flying by. In fact, it was this easy accessibility of local source code that pulled me into the open-source movement (I help maintain the FlatBuffers project as a volunteer). Furthermore, it gives me peace of mind in the unfortunate event that there are more security issues with Bottle generation: building from source decentralizes the creation of binary artifacts. It's clear that you spend a lot of time maintaining this project, and for that we are thankful. If you would please consider keeping HOMEBREW_BUILD_FROM_SOURCE available, for deeply-technical and curious enthusiasts like myself, I'm positive many of us on the nerdy fringes will continue to love this project.
There was a problem hiding this comment.
@rw You can still dig through the source code with brew install --interactive or brew install --build-from-source. You cannot globally tell Homebrew to build everything from source as it's a waste of both your time and our time when people file issues. Additionally, (and I'm not actually joking here) it's also a waste of energy to compile everything repeatedly unnecessarily.
We are not bringing back this variable, sorry.
- Add some `odeprecated` - Make some `odeprecated` now `odisabled` - Remove `odisabled` code. - Remove old update migrations - Remove GCC 4.0 compiler - Remove Tiger-only code - Remove 32-bit-only code - Remove use of LD64 - Remove GCC 4.3 - 4.8 support.
| @@ -15,7 +15,6 @@ class Version < ::Version | |||
| snow_leopard: "10.6", | |||
| leopard_64: "10.5", | |||
| leopard: "10.5", | |||
| tiger: "10.4", | |||
There was a problem hiding this comment.
This broke all casks referencing :tiger.
There was a problem hiding this comment.
@reitermarkus Homebrew/brew has never run on Tiger. Is there a brew readall equivalent for Homebrew/cask that we could add to CI to ensure that we don't break Cask syntax? Is there an open PR working on this or are you asking me to create one?
There was a problem hiding this comment.
@reitermarkus Note that support for pre-Mavericks is going to be dropped in 2.0.0 so it would be good if @homebrew/cask could work on some sort of tooling to make sure this doesn't happen again. For example I was notified through a CI failure and fixed Linuxbrew/homebrew-core issues in this PR.
There was a problem hiding this comment.
For example I was notified through a CI failure and fixed Linuxbrew/homebrew-core issues in this PR.
Thanks, Mike. I appreciate that.
Homebrew/brew has never supported these and the symbols have been removed in Homebrew/brew#5477.
Homebrew/brew has never supported these and the symbols have been removed in Homebrew/brew#5477.
Add some
odeprecatedMake some
odeprecatednowodisabledRemove
odisabledcode.Remove old update migrations
Remove GCC 4.0 compiler
Remove Tiger-only code
Remove 32-bit-only code
Remove use of LD64
Remove GCC 4.3 - 4.8 support.
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run
brew stylewith your changes locally?Have you successfully run
brew testswith your changes locally?