Disable cop for #set_cpu_flags, #set_cpu_cflags #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `extend/ENV/std.rb`, the methods `set_cpu_flags` and `set_cpu_cflags` have been violating the `Naming/AccessorMethodName` cop. A recent modification in #7e13b3749 woke up the cop. That means we’re likely dealing with legacy code here, predating the introduction of RuboCop into Homebrew. This commit disables the cop for either method. I believe refactoring wouldn’t currently be worth the effort, especially given that `#set_cpu_cflags` is mostly called without arguments.
|
Pinging @sjackman and @MikeMcQuaid for a second opinion, thanks in advance! |
|
Thanks for the PR but I'd like to be able to reproduce this |
|
(after rerunning build for 💚) |
|
Docker Hub is back to 💚. Thanks, Claudia! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally? No testsIn
extend/ENV/std.rb, the methodsset_cpu_flagsandset_cpu_cflagshave been violating theNaming/AccessorMethodNamecop.One of the changes in #5491 appears to have awakened the cop. That means we’re likely dealing with legacy code here, predating the introduction of RuboCop into Homebrew.
This PR disables the cop for either method. I believe refactoring wouldn’t currently be worth the effort, especially given that
#set_cpu_cflagsis now mostly called without arguments.