Use bundle install in more places.

[MikeMcQuaid]

This provides a more consistent version for rubocop than relying on Homebrew.install_gem_setup_path! (and we really want brew style to provide consistent output).

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[sjackman]

❯❯❯ brew style extend/ENV/std.rb
…
Fetching rubocop 0.62.0
Installing rubocop 0.62.0
…
== extend/ENV/std.rb ==
C:216:  7: Do not prefix writer method names with set_.

🎭

[sjackman]

❯❯❯ brew --version
Homebrew 1.8.6-127-gbb41fb7
Homebrew/homebrew-core (git revision 5c404c; last commit 2019-01-04)
Homebrew/homebrew-cask (git revision 0a80f; last commit 2018-12-04)
❯❯❯ brew style extend/ENV/std.rb
==> Installing or updating 'bundler' gem
Fetching: bundler-1.17.3.gem (100%)
Successfully installed bundler-1.17.3
1 gem installed
Fetching gem metadata from https://rubygems.org/........
Fetching ast 2.4.0
Using bundler 1.17.3
Fetching json 2.1.0
Fetching docile 1.3.1
Installing docile 1.3.1
Installing ast 2.4.0
Installing json 2.1.0 with native extensions
Fetching simplecov-html 0.10.2
Fetching tins 1.20.2
Installing simplecov-html 0.10.2
Installing tins 1.20.2
Fetching thor 0.19.4
Installing thor 0.19.4
Fetching diff-lcs 1.3
Fetching hpricot 0.8.6
Installing diff-lcs 1.3
Fetching jaro_winkler 1.5.2
Installing hpricot 0.8.6 with native extensions
Installing jaro_winkler 1.5.2 with native extensions
Fetching mustache 1.1.0
Installing mustache 1.1.0
Fetching parallel 1.12.1
Installing parallel 1.12.1
Fetching powerpack 0.1.2
Installing powerpack 0.1.2
Fetching rainbow 3.0.0
Installing rainbow 3.0.0
Fetching rdiscount 2.2.0.1
Installing rdiscount 2.2.0.1 with native extensions
Fetching rspec-support 3.8.0
Installing rspec-support 3.8.0
Fetching ruby-progressbar 1.10.0
Installing ruby-progressbar 1.10.0
Fetching unicode-display_width 1.4.1
Installing unicode-display_width 1.4.1
Fetching parser 2.5.3.0
Installing parser 2.5.3.0
Fetching term-ansicolor 1.7.0
Installing term-ansicolor 1.7.0
Fetching parallel_tests 2.27.1
Installing parallel_tests 2.27.1
Fetching simplecov 0.16.1
Installing simplecov 0.16.1
Fetching rspec-core 3.8.0
Installing rspec-core 3.8.0
Fetching rspec-expectations 3.8.2
Installing rspec-expectations 3.8.2
Fetching rspec-mocks 3.8.0
Installing rspec-mocks 3.8.0
Fetching rubocop 0.62.0
Installing rubocop 0.62.0
Fetching coveralls 0.8.22
Installing coveralls 0.8.22
Fetching simplecov-cobertura 1.3.0
Installing simplecov-cobertura 1.3.0
Fetching rspec-retry 0.6.1
Installing rspec-retry 0.6.1
Fetching rspec-its 1.2.0
Installing rspec-its 1.2.0
Fetching rspec 3.8.0
Installing rspec 3.8.0
Fetching rspec-wait 0.0.9
Installing rspec-wait 0.0.9
Fetching ronn 0.7.3
Installing ronn 0.7.3
Bundle complete! 10 Gemfile dependencies, 33 gems now installed.
Bundled gems are installed into `./vendor/bundle`
== extend/ENV/std.rb ==
C:216:  7: Do not prefix writer method names with set_.

1 file inspected, 1 offense detected

[sjackman]

❯❯❯ brew config
HOMEBREW_VERSION: 1.8.6-127-gbb41fb7
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: bb41fb7ade9809a177c3303b251fcc0eea6521d8
Last commit: 4 minutes ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 5c404cfede6cf79a8234ec2e4c6336b0802ff2c0
Core tap last commit: 3 days ago
HOMEBREW_PREFIX: /Users/sjackman/.homebrew
HOMEBREW_REPOSITORY: /Users/sjackman/.homebrew/Homebrew
HOMEBREW_CELLAR: /Users/sjackman/.homebrew/Cellar
HOMEBREW_BINTRAY_KEY: set
HOMEBREW_BINTRAY_USER: sjackman
HOMEBREW_CASK_OPTS: --appdir=/Users/sjackman/Applications
HOMEBREW_CIRCLE_TOKEN: set
HOMEBREW_DEVELOPER: 1
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_LOGS: /Users/sjackman/Library/Logs/Homebrew
HOMEBREW_NO_AUTO_UPDATE: 1
HOMEBREW_NO_INSTALL_CLEANUP: 1
HOMEBREW_VISUAL: gvim
CPU: quad-core 64-bit ivybridge
Homebrew Ruby: 2.3.7 => /Users/sjackman/.homebrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/bin/ruby
Clang: 8.0 build 800
Git: 2.17.0 => /Users/sjackman/.homebrew/opt/git/bin/git
Curl: 7.43.0 => /usr/bin/curl
Java: 1.8.0_73
macOS: 10.11.6-x86_64
CLT: 8.2.0.0.1.1480973914
Xcode: 8.2.1
XQuartz: 2.7.8 => /opt/X11

[sjackman]

Docker Hub is also failing with this same brew style error.

==> brew style
==> FAILED
Inspecting 729 files
..............................................................................................................................................................................................................................................................C..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
.linuxbrew/Homebrew/Library/Homebrew/extend/ENV/std.rb:216:7: C: Do not prefix writer method names with set_.
def set_cpu_cflags(map = Hardware::CPU.optimization_flags)
^^^^^^^^^^^^^^
729 files inspected, 1 offense detected

https://cloud.docker.com/u/linuxbrew/repository/registry-1.docker.io/linuxbrew/brew/hub-builddetail/b4roqdkngrjvyl4mrjcqjgg

This issue is reproducible locally by me on macOS and by Docker Hub on Linux.

[sjackman]

$ git checkout 1.8.6
$ brew style extend/ENV/std.rb
1 file inspected, no offenses detected
$ git checkout master
$ brew --version
Homebrew 1.8.6-126-g464b41e
$ brew style extend/ENV/std.rb
== extend/ENV/std.rb ==
C:216:  7: Do not prefix writer method names with set_.

The code in extend/ENV/std.rb hasn't changed. The issue appears to be in Homebrew's Rubocop.

[sjackman]

My laptop at home also reports…

❯❯❯ brew style extend/ENV/std.rb
== extend/ENV/std.rb ==
C:216:  7: Do not prefix writer method names with set_.

[MikeMcQuaid]

Reverting Rubocop upgrades here due to rubocop/rubocop#6625 which breaks brew style.