Add prepend! for ImagineSignal traces, stimulus control example #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdw503
reviewed
Jul 6, 2023
src/imaginesignal.jl
Outdated
| #TODO: run safety checks here | ||
| #find the length of this sequence and append to cumlength vector | ||
| seqi = findfirst(x->x==seqname, sequence_names(com)) | ||
| prepend!(sequence_names(com), [seqname]) |
There was a problem hiding this comment.
compare to ImagineInterface.append! method, below would be better?
pushfirst!(sequence_names(com), seqname)
src/imaginesignal.jl
Outdated
| seqi = findfirst(x->x==seqname, sequence_names(com)) | ||
| prepend!(sequence_names(com), [seqname]) | ||
| newseq = sequence_lookup(com)[seqname] | ||
| prepend!(sequences(com), [newseq]) |
There was a problem hiding this comment.
also
pushfirst!(sequences(com), newseq)
?
src/imaginesignal.jl
Outdated
| lseq = cumlength(com)[seqi] - cumlength(com)[seqi-1] | ||
| end | ||
| com.cumlength .+= lseq | ||
| prepend!(com.cumlength, lseq) |
There was a problem hiding this comment.
also
pushfirst!(com.cumlength, lseq)
?
src/imaginesignal.jl
Outdated
Comment on lines
411
to
414
| prepend!(sequences(com), [sequence]) | ||
| prepend!(sequence_names(com), [seqname]) | ||
| com.cumlength .+= full_length(sequence) | ||
| prepend!(com.cumlength, full_length(sequence)) |
|
@tmcgrath325, want to respond to these suggestions and then I can give you the next round of review? |
The tests are similar to the planned usage for prepend!, adding a constant value before an experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
prepend!is intended to be a convenient way to allow for padding the beginnings of traces, rather than requiring traces be constructed from beginning to end.I've also added a modified example workflow script that shows how a stimulus signal can be set up for control of the autosampler.