Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @:require vs overload #10891

Merged
merged 6 commits into from
Dec 16, 2022
Merged

Fix @:require vs overload #10891

merged 6 commits into from
Dec 16, 2022

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Dec 15, 2022 •
edited
Loading

Fixes #10890

@Simn
Copy link
Member

Simn commented Dec 15, 2022

Huh, isn't this basically a new feature if we allow it to subvert these restrictions? We seem to be mixing the concepts of @:require and conditional compilation here.

@kLabz
Copy link
Contributor Author

kLabz commented Dec 15, 2022

Huh, isn't this basically a new feature if we allow it to subvert these restrictions? We seem to be mixing the concepts of @:require and conditional compilation here.

Uh, right...

@kLabz kLabz changed the title Fix @:require and false duplicate reports Fix @:require vs overload Dec 15, 2022
@Simn Simn merged commit 66a53c6 into HaxeFoundation:development Dec 16, 2022
@kLabz kLabz deleted the fix/10890 branch December 16, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[js] overload and @:require cannot be put together
2 participants
@kLabz @Simn