refactor: Remove stale references to flake8 #1625
Conversation
|
Thanks for contributing with this PR to clean up GT4Py!
Just run: |
|
@egparedes thanks for the quick reply and the pointers. I could run the |
fec69b2 to
6cbec77
Compare
|
I hadn't realized that the CI checks were waiting for explicit approval of a member of the developers' group and didn't run automatically. I've triggered them now and as soon as they finish I'll approve the PR. In the meantime, please merge back the changes from main in this PR to make sure everything works fine. |
Flake8 was removed in the past in favor of the ruff [1] linter and formatter. [1] https://astral.sh/ruff
linters run as part of pre-commit and don't need to re-run as part of tox tests.
- ran `tox r -e requirements-base` - checked (and fixed) the mypy mirror version in .pre-commit-config.yaml
This commit runs `pre-commit run -a` to run the new version of `ruff` and `ruff-format` on all files. This changes some examples and notebooks.
6b61804 to
152981b
Compare
|
@egparedes Thanks for starting the tests. I rebased my branch on top of |
|
cscs-ci run default |
|
@romanc Thanks again for your contribution. I've approved and already merged the PR myself because I want to add these changes to another PR I'm working on. |
|
Thanks for merging @egparedes. Happy to contribute! |
Description
In PR #1466,
flake8,black, andisortwere replaced with the ruff linter and formatter. It seems there are a few leftovers of this transition. In this PR, I did a quick search for flake8 and deleted / replaced all instances found.Removing
flake8means rebuilding the requirements (to propagate the changes to the frozenrequirements-*files), which updates a couple of dependencies.We also decided to remove the
linter-*tasks oftoxsince they have been replaced bypre-commit.Requirements
If this PR contains code authored by new contributors please make sure:
AUTHORS.mdfile adding the names of all the new contributors.