-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[cartesian]: Enable MaskInlining in gt4yp - DaCe bridge #1624
Conversation
@havogt I have a question about linting in gt4py. I ran Is that expected behavior? |
We should not be using flake8 anymore. @egparedes there seem to be a few leftovers. |
I see, I can make a second PR to remove flake8 (in favor of ruff): see #1625. |
6c7a266
to
5f5e0d7
Compare
With #1625 merged this PR rebased to /cc @FlorianDeconinck adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Yay for clean up \o/
cscs-ci run default |
Looks like I don't have permission to kick off the cscs/default CI. Can someone with proper rights do this for me? Thanks! |
cscs-ci run default |
@egparedes thanks for running cscs tests. Please go ahead and merge (as I don't have write access to this repository). |
Description
MaskInlining
will be a key feature of the improved gt4py / DaCe bridge as envisioned in GEOS-ESM/NDSL#53, which will propagate more control flow elements from gt4py to DaCe. We thus want to make sure ifMaskInlining
itself is posing any problems. We tracked the git history of this explicit exclude back to PR #300, which not only added the npir backend, but also refactored how pipeline stages are defined. Previous to this PR optimization passes to be specified explicitly and the PR changed this to an exclude list. It looks like theMaskInlining
pass was added after the list of optimization passes was formed and thus excluded (to keep the list constant). From this history we thus don't expectMaskInlining
to break anything.Requirements
If this PR contains code authored by new contributors please make sure:
AUTHORS.md
file adding the names of all the new contributors.