-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor : 티켓 타입 기획 수정 반영 #339
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...ng-Domain/src/main/java/band/gosrock/domain/domains/ticket_item/domain/TicketPayType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package band.gosrock.domain.domains.ticket_item.domain; | ||
|
||
|
||
import com.fasterxml.jackson.annotation.JsonValue; | ||
import lombok.AllArgsConstructor; | ||
import lombok.Getter; | ||
|
||
@Getter | ||
@AllArgsConstructor | ||
public enum TicketPayType { | ||
// 두둥티켓 | ||
DUDOONG_TICKET("DUDOONG_TICKET", "두둥티켓"), | ||
// 무료티켓 | ||
FREE_TICKET("FREE_TICKET", "무료티켓"), | ||
// 유료티켓 | ||
PRICE_TICKET("PRICE_TICKET", "유료티켓"); | ||
|
||
private String value; | ||
|
||
@JsonValue private String kr; | ||
} |
13 changes: 13 additions & 0 deletions
13
...n/java/band/gosrock/domain/domains/ticket_item/exception/EmptyAccountNumberException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package band.gosrock.domain.domains.ticket_item.exception; | ||
|
||
|
||
import band.gosrock.common.exception.DuDoongCodeException; | ||
|
||
public class EmptyAccountNumberException extends DuDoongCodeException { | ||
|
||
public static final DuDoongCodeException EXCEPTION = new EmptyAccountNumberException(); | ||
|
||
private EmptyAccountNumberException() { | ||
super(TicketItemErrorCode.EMPTY_ACCOUT_NUMBER); | ||
} | ||
} |
13 changes: 13 additions & 0 deletions
13
.../main/java/band/gosrock/domain/domains/ticket_item/exception/InvalidPartnerException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package band.gosrock.domain.domains.ticket_item.exception; | ||
|
||
|
||
import band.gosrock.common.exception.DuDoongCodeException; | ||
|
||
public class InvalidPartnerException extends DuDoongCodeException { | ||
|
||
public static final DuDoongCodeException EXCEPTION = new InvalidPartnerException(); | ||
|
||
private InvalidPartnerException() { | ||
super(TicketItemErrorCode.INVALID_PARTNER); | ||
} | ||
} |
13 changes: 13 additions & 0 deletions
13
...in/java/band/gosrock/domain/domains/ticket_item/exception/InvalidTicketTypeException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package band.gosrock.domain.domains.ticket_item.exception; | ||
|
||
|
||
import band.gosrock.common.exception.DuDoongCodeException; | ||
|
||
public class InvalidTicketTypeException extends DuDoongCodeException { | ||
|
||
public static final DuDoongCodeException EXCEPTION = new InvalidTicketTypeException(); | ||
|
||
private InvalidTicketTypeException() { | ||
super(TicketItemErrorCode.INVALID_TICKET_TYPE); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,9 +18,8 @@ public class TicketItemService { | |
|
||
@Transactional | ||
public TicketItem createTicketItem(TicketItem ticketItem, Boolean isPartner) { | ||
if (!isPartner) { | ||
ticketItem.validateTicketPrice(); | ||
} | ||
|
||
ticketItem.validateTicketPayType(isPartner); | ||
Comment on lines
-21
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 굿 잘 집어넣으셨네용 |
||
return ticketItemAdaptor.save(ticketItem); | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이러면 스웨거엔 한글로 뜰텐데
입력받을 땐 DUDOONG_TICKET
이렇게 입력받아야 하지않나염?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어라 저희 스웨거 한글로 통일한거 아녔나여??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅇㅇㅇ 근데
이러면 클라이언트가 한글로 입력하면 변환되나?
내려주는건 한글인데
스웨거 스키마 가면 죄다 한글이라서 뭐로 입력해야하는지 모르자넹
한글로 입력받을 수 있나? JsonCreater 같은걸로
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그냥 두둥티켓, 무료티켓, 유료티켓 이렇게 입력하게 해놧는디?
승인타입이랑 마찬가지로
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 그렇게 하면 받아짐? 굿굿 잘했넹 ㅇㅋㅇㅋ