refactor : 티켓 타입 기획 수정 반영 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
approved these changes
Feb 10, 2023
| if (!this.type.equals(TicketType.APPROVAL)) { | ||
| throw InvalidTicketTypeException.EXCEPTION; | ||
| } | ||
| if (this.accountNumber == null || this.accountNumber.isBlank()) { |
|
|
||
| private String value; | ||
|
|
||
| @JsonValue private String kr; |
There was a problem hiding this comment.
이러면 스웨거엔 한글로 뜰텐데
입력받을 땐 DUDOONG_TICKET
이렇게 입력받아야 하지않나염?
There was a problem hiding this comment.
어라 저희 스웨거 한글로 통일한거 아녔나여??
There was a problem hiding this comment.
ㅇㅇㅇ 근데
이러면 클라이언트가 한글로 입력하면 변환되나?
내려주는건 한글인데
스웨거 스키마 가면 죄다 한글이라서 뭐로 입력해야하는지 모르자넹
한글로 입력받을 수 있나? JsonCreater 같은걸로
There was a problem hiding this comment.
그냥 두둥티켓, 무료티켓, 유료티켓 이렇게 입력하게 해놧는디?
승인타입이랑 마찬가지로
Comment on lines
153
to
177
| if (this.payType.equals(TicketPayType.DUDOONG_TICKET)) { | ||
| if (!this.type.equals(TicketType.APPROVAL)) { | ||
| throw InvalidTicketTypeException.EXCEPTION; | ||
| } | ||
| if (this.accountNumber == null || this.accountNumber.isBlank()) { | ||
| throw EmptyAccountNumberException.EXCEPTION; | ||
| } | ||
| } | ||
| // 유료티켓은 무조건 선착순 + 제휴 확인 + 1000원 이상 | ||
| else if (this.payType.equals(TicketPayType.PRICE_TICKET)) { | ||
| if (!this.type.equals(TicketType.FIRST_COME_FIRST_SERVED)) { | ||
| throw InvalidTicketTypeException.EXCEPTION; | ||
| } | ||
| if (!isPartner) { | ||
| throw InvalidPartnerException.EXCEPTION; | ||
| } | ||
| if (this.price.isLessThan(Money.wons(1000))) { | ||
| throw InvalidTicketPriceException.EXCEPTION; | ||
| } | ||
| } | ||
| // 무료티켓은 무조건 0원 | ||
| else { | ||
| if (!this.price.equals(Money.ZERO)) { | ||
| throw InvalidTicketPriceException.EXCEPTION; | ||
| } |
There was a problem hiding this comment.
TicketPayType 이넘안에서
메소드 하나 만들고 각 이넘 값마다 ( 두둥티켓 , 무료 티켓 , 유료티켓
오버라이딩을 밸리데이션을 안에서 해버리면
더 깔끔할것같긴해요
레퍼런스
- https://github.com/Gosrock/DuDoong-Backend/blob/dev/DuDoong-Api/src/main/java/band/gosrock/api/common/aop/hostRole/HostQualification.java
- https://github.com/Gosrock/DuDoong-Backend/blob/dev/DuDoong-Domain/src/main/java/band/gosrock/domain/domains/order/repository/condition/AdminTableSearchType.java
근데 이건뭐 자율입니당
참고요! 안바꿔도 됨
ImNM
approved these changes
Feb 10, 2023
Comment on lines
-21
to
+22
| if (!isPartner) { | ||
| ticketItem.validateTicketPrice(); | ||
| } | ||
|
|
||
| ticketItem.validateTicketPayType(isPartner); |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
두둥티켓 타입 추가
기존 ticketType -> approveType
새로운 지불타입 -> payType 으로 네이밍
TicketType(현 승인타입) 은 결제, 발행티켓 등 쓰이는 곳이 많아서 최대한 네이밍 안건드리고,
클라이언트 쪽에서 헷갈리지 않을 정도로만 처리했습니다.
결과
재고 공개 옵션 입력값 추가
변경로직