Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : 이벤트 슬랙 알림 #332

Merged
merged 6 commits into from
Feb 10, 2023
Merged

feat : 이벤트 슬랙 알림 #332

merged 6 commits into from
Feb 10, 2023

Conversation

gengminy
Copy link
Member

@gengminy gengminy commented Feb 10, 2023 •
edited
Loading

개요

작업사항

  • 이벤트 관련 슬랙 알림 추가
  • 이벤트 불필요한 필드인 ticketing 시간 관련 필드 제거
  • 비동기 에러 로그 처리를 위한 도메인 이벤트 @ToString 추가

변경로직

  • 내용을 적어주세요.

@gengminy gengminy added For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Feb 10, 2023
@gengminy gengminy self-assigned this Feb 10, 2023
sanbonai06
sanbonai06 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ImNM
ImNM approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠

...ng-Domain/src/main/java/band/gosrock/domain/common/events/event/EventContentChangeEvent.java

@Getter
@Builder
public class EventContentChangeEvent extends DomainEvent {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이벤트마다 롬복
toString 부탁드릴게유!
디버깅용!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인이요

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 320 Code Smells

16.2% 16.2% Coverage
0.0% 0.0% Duplication

@gengminy gengminy merged commit b0ba639 into dev Feb 10, 2023
@gengminy gengminy deleted the feature/331-event-slack branch February 10, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@ImNM ImNM ImNM approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@gengminy gengminy

Labels
For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
두둥
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 이벤트 슬랙 알림 추가
3 participants
@gengminy @ImNM @sanbonai06