feature : async error handler with slack alarm #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
commented
Feb 7, 2023
Comment on lines
+45
to
+62
|
|
||
| @Async | ||
| public void sendNotification(List<LayoutBlock> layoutBlocks) { | ||
| if (!isNeedToNotificationProfile()) { | ||
| return; | ||
| } | ||
| ChatPostMessageRequest chatPostMessageRequest = | ||
| ChatPostMessageRequest.builder() | ||
| .channel(CHANNEL_ID) | ||
| .text("") | ||
| .blocks(layoutBlocks) | ||
| .build(); | ||
| try { | ||
| methodsClient.chatPostMessage(chatPostMessageRequest); | ||
| } catch (SlackApiException | IOException slackApiException) { | ||
| log.error(slackApiException.toString()); | ||
| } | ||
| } |
| import org.springframework.web.util.ContentCachingRequestWrapper; | ||
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| @Slf4j | ||
| public class SlackApiProvider { | ||
| private final MethodsClient methodsClient; | ||
| public class SlackInternalErrorSender { |
There was a problem hiding this comment.
해당 샌더는
api 모듈에 config 에서 slack 패키지로 위치를 이동시켰습니다
@gengminy 경민형이 아마 여기서 유저랑 우리 를 위한 슬랙 샌더 작업하시면 될것같습니다
Comment on lines
-102
to
+74
| ChatPostMessageRequest chatPostMessageRequest = | ||
| ChatPostMessageRequest.builder() | ||
| .channel(CHANNEL_ID) | ||
| .text("") | ||
| .blocks(layoutBlocks) | ||
| .build(); | ||
| try { | ||
| methodsClient.chatPostMessage(chatPostMessageRequest); | ||
| } catch (SlackApiException slackApiException) { | ||
| log.error(slackApiException.toString()); | ||
| } | ||
| slackProvider.sendNotification(layoutBlocks); |
There was a problem hiding this comment.
layoutBlocks 을 인자로 받아서
보냅니다
비동기 관련 어노테이션은
slackProvider.sendNotification
해당 메소드로 위치시켰습니다.
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직
그리구 앞으로 도메인 이벤트에 롬복 tostring 달아주시면 감사하겠습니다.!
비동기 요청으로 넘어온 파라미터들을 받을 수 있는데
로그로 남겨서 위 사진에 요청 파라미터처럼 내용이보이면 디버깅 하기 더 쉬울듯 합니다!