Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortpixel Image Optimizer Incompatibility #11837

Merged
merged 19 commits into from
Jul 6, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests/phpunit/integration/tests/Integrations/ShortPixel.php
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
  • Loading branch information
timarney and spacedmonkey authored Jun 29, 2022
commit 18c291fb91005e6036db3bab555582fad60eb454
3 changes: 1 addition & 2 deletions tests/phpunit/integration/tests/Integrations/ShortPixel.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,9 @@ public function test_image_urls(): void {
* @covers ::image_urls
*/
public function test_image_urls_non_page_template_image(): void {
$short_pixel = new \Google\Web_Stories\Integrations\ShortPixel();
/* given a non "page-template" image the urls should pass thru */
$urls = [ 'http://localhost:8899/wp-content/uploads/2022/03/example-750.jpg' ];
$result = $short_pixel->image_urls( $urls, 10 );
$result = $this->instance->image_urls( $urls, 10 );
$this->assertEqualSets( $urls, $result );
}
}