Shortpixel Image Optimizer Incompatibility #11837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example payload |
swissspidy
reviewed
Jun 29, 2022
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
spacedmonkey
suggested changes
Jun 29, 2022
spacedmonkey
approved these changes
Jun 30, 2022
swissspidy
reviewed
Jun 30, 2022
swissspidy
reviewed
Jun 30, 2022
swissspidy
reviewed
Jun 30, 2022
Co-authored-by: Pascal Birchler <pascalb@google.com>
swissspidy
approved these changes
Jun 30, 2022
|
Size Change: +3.85 kB (0%) Total Size: 2.64 MB
ℹ️ View Unchanged
|
|
Plugin builds for de55079 are ready 🛎️!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Plugins like Shortpixel are used for image optimizations within WordPress.
We upload an image for every custom saved page template. These are only used in the editor and should not be optimized by Shortpixel.
Summary
Adds a filter per
#10797 (comment)
To check for a page template image and prevent the optimization
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Via #10797
6 In Shortpixel stats, see that it cost a credit to optimize the page template image
Note: Another way to test is to add a media image with
web-stories-page-templatein the name.Press the
Optimize now button-- watch the Network tab (ajax request) + responseReviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #10797