-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: kokoro v4 test #9658
fix: kokoro v4 test #9658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary of the changes for you and other reviewers to quickly get up to speed:
This pull request, "Fix kokoro v4 test", aims to address issues with the kokoro v4 test. The description mentions it's a draft PR related to Makefile changes in #9657. Based on the code changes, I can infer the following:
- New GitHub Workflow: A new GitHub workflow,
.github/workflows/compile-mac.yaml
, has been added to cross-compile skaffold on MacOS. This workflow triggers on push and pull request events and includes steps to check out code, set up Docker, and build skaffold binaries for various platforms (linux-amd64, darwin-amd64, windows-amd64.exe, linux-arm64, darwin-arm64). - Makefile Modifications: The
Makefile
has been updated. Specifically, line 14 adds aGOVERSION
variable set to1.23.4
. More significantly, lines 96-126 in theMakefile
have been extensively revised to use a docker image (docker.elastic.co/beats-dev/golang-crossbuild:$(GOVERSION)-$(image_platform)-debian12
) for cross compilation, rather than relying on the system's Go toolchain. This change likely improves the consistency and reliability of cross-compilation across different environments.
Summary Table:
File | Changes |
---|---|
.github/workflows/compile-mac.yaml |
Added a new workflow for cross-compiling skaffold on MacOS. |
Makefile |
Added GOVERSION variable (line 14) and significantly revised cross-compilation logic (lines 96-126) using a docker image. |
I'll provide a more detailed review shortly. Thanks!
And now, a little haiku to brighten your day:
Code flows like a stream,
Tests run, a gentle cascade,
Bugs flee in the night.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR introduces a GitHub Actions workflow to cross-compile Skaffold on macOS and updates the Makefile to use a Docker image for cross-compilation. This addresses the Kokoro v4 test issue by providing a consistent build environment. The changes look good overall, but there are a few points to consider.
Draft-PR.
This branch was created to run a github action that tests the makefile changes in #9657