chore: exclude commons logging from artifacts. #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhumin8
commented
Dec 5, 2023
| @@ -24,10 +24,5 @@ | |||
| <artifactId>spring-cloud-gcp-vision</artifactId> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
This dependency is redundant as it's part of spring-cloud-gcp-vision above.
|
Kudos, SonarCloud Quality Gate passed!
|
|
If we merge this PR, please create an issue to remove it once googleapis/google-http-java-client#1905 has been released. |
burkedavison
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Boot starters ships with
spring-jclmodule (doc), which comes with its own Commons Logging bridge implemented in thespring-jclmodule (Spring Framework doc ). This has potential conflicts with commons-logging.jar from classpath.In particular, this causes failure for native compilation when logging gets accidentally initialized at runtime instead of build time.
This pr tries to exclude
commons-loggingfrom SCGCP artifacts. With 2 exceptions: preview modules andspanner-data-spring-data-r2dbcmodule.Also removes this flag for native builds:
<buildArg>--initialize-at-build-time=org.apache.commons.logging.LogFactory</buildArg>