Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commons-logging from classpath #2000

Closed
burkedavison opened this issue Jul 5, 2023 · 2 comments
Closed

Remove commons-logging from classpath #2000

burkedavison opened this issue Jul 5, 2023 · 2 comments
Assignees
Labels
priority: p3 type: bug Something isn't working

Comments

@burkedavison
Copy link
Member

burkedavison commented Jul 5, 2023

Pubsub-stream-binder and logging integration tests produce this message:

Standard Commons Logging discovery in action with spring-jcl: please remove commons-logging.jar from classpath in order to avoid potential conflicts

(Example log)

This dependency is brought in via spring-cloud-gcp-logging's com.google.cloud:google-cloud-logging-logback dependency,
and spring-cloud-gcp-pubsub's com.google.cloud:google-cloud-pubsub dependency.

@zhumin8
Copy link
Contributor

zhumin8 commented Dec 4, 2023

Adding a note: we should remove commons-logging from classpath for all artifacts published via SCGCP

@zhumin8 zhumin8 self-assigned this Dec 4, 2023
@zhumin8
Copy link
Contributor

zhumin8 commented Dec 14, 2023

fixed by #2407, and remaining cleanup after googleapis/google-http-java-client#1905 has been released captured in #2415. Thus closing this one.

@zhumin8 zhumin8 closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants