Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove oauth2client from AppEngine Standard Firebase #3718

Merged
merged 5 commits into from
May 13, 2020
Merged

Remove oauth2client from AppEngine Standard Firebase #3718

merged 5 commits into from
May 13, 2020

Conversation

busunkim96
Copy link
Contributor

Closes #2648

This is the last project using oauth2client. search result

@busunkim96 busunkim96 requested a review from a team as a code owner May 11, 2020 17:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 11, 2020
@busunkim96
Copy link
Contributor Author

Ah, I was looking at this too quickly. Looks like this is really a httplib2 -> requests upgrade. Working on another commit.

@tmatsuo tmatsuo added the automerge Merge the pull request once unit tests and other checks pass. label May 13, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 41d7204 into master May 13, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the firebase-oauth2client branch May 13, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees

@gguuss gguuss

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove oauth2client usage
4 participants
@busunkim96 @tmatsuo @gguuss @googlebot