Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove oauth2client usage #2648

Closed
busunkim96 opened this issue Dec 23, 2019 · 4 comments · Fixed by #3718
Closed

Remove oauth2client usage #2648

busunkim96 opened this issue Dec 23, 2019 · 4 comments · Fixed by #3718
Assignees
@busunkim96
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@busunkim96
Copy link
Contributor

oauth2client is deprecated. Samples using oauth2client should be updated to use google-auth instead.
@busunkim96 busunkim96 added the type: cleanup An internal cleanup or hygiene concern. label Dec 23, 2019
@busunkim96 busunkim96 assigned busunkim96 and unassigned dmahugh Dec 23, 2019
@andrewferlitsch
Copy link
Contributor

@busunkim96 PTAL

@busunkim96
Copy link
Contributor Author

This is still relevant, but I haven't been able to prioritize it.

grant added a commit that referenced this issue May 11, 2020
@grant
chore: remove unused oauth2client in healthcare
6b81e0f 
Part of #2648
@grant grant mentioned this issue May 11, 2020
Merged
@grant
Copy link
Contributor

grant commented May 11, 2020

I believe the usages are all in folder appengine/standard, which is likely de-prioritized.

tmatsuo pushed a commit that referenced this issue May 11, 2020
@grant
chore: remove unused oauth2client in healthcare (#3716)
2d3a7d3 
Part of #2648
@busunkim96
Copy link
Contributor Author

It looks like there is one remaining usage of this.

appengine/standard/firebase/firetactoe

Will open a PR shortly to clean this up.

@busunkim96 busunkim96 mentioned this issue May 11, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue May 13, 2020
@busunkim96
Remove oauth2client from AppEngine Standard Firebase (#3718)
41d7204 
Closes #2648 

This is the last project using oauth2client. [search result](https://github.com/GoogleCloudPlatform/python-docs-samples/search?q=oauth2client&unscoped_q=oauth2client)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove oauth2client from AppEngine Standard Firebase GoogleCloudPlatform/python-docs-samples
4 participants
@grant @dmahugh @busunkim96 @andrewferlitsch