Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump ipython version to address compilation issues with py3.8 #3667

Merged
merged 2 commits into from
May 1, 2020
Merged

fix: bump ipython version to address compilation issues with py3.8 #3667

merged 2 commits into from
May 1, 2020

Conversation

shollyman
Copy link
Contributor

Fixes: #3658
Fixes: #3659
Fixes: #3660

@shollyman shollyman requested a review from a team as a code owner May 1, 2020 17:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented May 1, 2020

@shollyman Thanks for the quick fix!
Unfortunately, now we still don't run python-3.8 presubmit, but I confirmed that it's passing on my workstation. LGTM

@tmatsuo
Copy link
Contributor

tmatsuo commented May 1, 2020

I don't know why, but there's no jobs queued in Kokoro. Let me update the branch, so that Kokoro will run the test again. I'll merge once the tests pass.

@tmatsuo tmatsuo merged commit af91571 into GoogleCloudPlatform:master May 1, 2020
@shollyman shollyman deleted the fix_datalab_tests branch May 1, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees

@tmatsuo tmatsuo

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
3 participants
@shollyman @tmatsuo @googlebot