Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery.datalab-migration.samples_test: test_client_library_magic_parameterized_query failed #3660

Closed
flaky-bot bot opened this issue May 1, 2020 · 2 comments · Fixed by #3667
Closed
Assignees
Labels
api: bigquery Issues related to the BigQuery API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 1, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.


commit: ca6200a
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 1, 2020
@tmatsuo tmatsuo assigned tmatsuo and unassigned gguuss May 1, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented May 1, 2020

This is a failure with the new py-3.8 build.

@tmatsuo
Copy link
Contributor

tmatsuo commented May 1, 2020

The excerpt from the log:

________________ test_client_library_magic_parameterized_query _________________
Traceback (most recent call last):
  File "/tmpfs/src/github/python-docs-samples/bigquery/datalab-migration/samples_test.py", line 229, in test_client_library_magic_parameterized_query
    assert len(df) == 10
AssertionError: assert 100 == 10
  -100
  +10
----------------------------- Captured stdout call -----------------------------
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/usr/local/lib/python3.8/codeop.py in __call__(self, source, filename, symbol)
    131 
    132     def __call__(self, source, filename, symbol):
--> 133         codeob = compile(source, filename, symbol, self.flags, 1)
    134         for feature in _features:
    135             if codeob.co_flags & feature.compiler_flag:

TypeError: required field "type_ignores" missing from Module
Traceback (most recent call last):

  File "/tmpfs/src/github/python-docs-samples/bigquery/datalab-migration/.nox/py-3-8/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 3267, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)

  File "<ipython-input-1-93dd364fb9c2>", line 1, in <module>
    get_ipython().run_cell_magic('bigquery', '--params $params', 'SELECT word, SUM(word_count) as count\nFROM `bigquery-public-data.samples.shakespeare`\nWHERE corpus = @corpus_name\nGROUP BY word\nORDER BY count ASC\nLIMIT @limit\n\n')

  File "/tmpfs/src/github/python-docs-samples/bigquery/datalab-migration/.nox/py-3-8/lib/python3.8/site-packages/google/datalab/kernel/__init__.py", line 92, in _run_cell_magic
    return _orig_run_cell_magic(self, magic_name, line, cell)

  File "/tmpfs/src/github/python-docs-samples/bigquery/datalab-migration/.nox/py-3-8/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 2323, in run_cell_magic
    result = fn(magic_arg_s, cell)

  File "/tmpfs/src/github/python-docs-samples/bigquery/datalab-migration/.nox/py-3-8/lib/python3.8/site-packages/google/cloud/bigquery/magics.py", line 481, in _cell_magic
    raise SyntaxError(

  File "<string>", line unknown
SyntaxError: --params is not a correctly formatted JSON string or a JSON serializable dictionary

@tmatsuo tmatsuo added the api: bigquery Issues related to the BigQuery API. label May 1, 2020
@tmatsuo tmatsuo assigned shollyman and unassigned tmatsuo May 1, 2020
tmatsuo pushed a commit that referenced this issue May 1, 2020
…3667)

Fixes: #3658
Fixes: #3659
Fixes: #3660

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants