Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support JDBC PreparedStatement #23

Closed
wants to merge 2 commits into from

Conversation

olavloite
Copy link
Collaborator

Adds integration tests that use the native PostgreSQL driver to connect
to PGAdapter, and tweaks the protocol response from PGAdapter to be in
line with what real PostgreSQL does. Notable changes to protocol:

  1. standard_conforming_strings should return 'on' instead of 'true'
  2. Describe Portal should respond with NoData if the portal does not
    contain any columns (i.e. it is an update count)

Adds support for decoding parameters that have been given in binary
format.

This change also fixes a wrong assumption in IntermediateStatement that
a zero update count means NO_RESULT. Zero update count means that no
rows were updated/deleted by the UPDATE or DELETE statement.

Adds integration tests that use the native PostgreSQL driver to connect
to PGAdapter, and tweaks the protocol response from PGAdapter to be in
line with what real PostgreSQL does. Notable changes to protocol:

1. standard_conforming_strings should return 'on' instead of 'true'
2. Describe Portal should respond with NoData if the portal does not
   contain any columns (i.e. it is an update count)

Adds support for decoding parameters that have been given in binary
format.

This change also fixes a wrong assumption in IntermediateStatement that
a zero update count means NO_RESULT. Zero update count means that no
rows were updated/deleted by the UPDATE or DELETE statement.
@olavloite olavloite marked this pull request as ready for review January 27, 2022 20:06
@olavloite
Copy link
Collaborator Author

Replaces #20

@olavloite
Copy link
Collaborator Author

@Vizerai I don't know if you had already started looking into this, but I've broken it up into a number of smaller parts to make it a little easier:

Once those are merged, I'll rebase this one so we can get in all the JDBC integration tests.

@olavloite olavloite marked this pull request as draft February 4, 2022 08:13
@olavloite
Copy link
Collaborator Author

Closing as this has been replaced by a number of smaller PRs containing the same plus additional features.

@olavloite olavloite closed this Feb 11, 2022
@olavloite olavloite deleted the jdbc-prepared-statements branch March 6, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant