test: add integration tests using PG native JDBC driver #20
Conversation
Adds integration tests that use the native PostgreSQL driver to connect to PGAdapter, and tweaks the protocol response from PGAdapter to be in line with what real PostgreSQL does. Notable changes to protocol: 1. standard_conforming_strings should return 'on' instead of 'true' 2. Describe Portal should respond with NoData if the portal does not contain any columns (i.e. it is an update count) This change also fixes a wrong assumption in IntermediateStatement that a zero update count means NO_RESULT. Zero update count means that no rows were updated/deleted by the UPDATE or DELETE statement.
|
cc @voulg @tinaspark @snehashah16 @Vizerai I don't have access to the main repository, so I cannot add any of you as reviewers (and I have to create the PR from a fork). PTAL. The tests are failing, as GitHub Actions cannot download the required dependencies, and does not have access to the credentials needed for integration tests. |
| this.executed = false; | ||
| this.exception = null; | ||
| this.resultType = null; | ||
| this.hasMoreData = false; | ||
| this.statementResult = null; | ||
| this.updateCount = null; |
There was a problem hiding this comment.
Removed, as this is a no-op (it just sets a number of properties to their default values)
|
|
||
| /** | ||
| * Extracts what type of result exists within the statement. In JDBC a statement update count is | ||
| * positive if it is an update statement, 0 if there is no result, or negative if there are |
There was a problem hiding this comment.
A zero update count does not mean that there is no result. It means that zero rows were updated/deleted.
| @@ -102,7 +102,7 @@ public static void sendStartupMessage( | |||
| new ParameterStatusResponse(output, "client_encoding".getBytes(), "utf8".getBytes()).send(); | |||
| new ParameterStatusResponse(output, "DateStyle".getBytes(), "ISO".getBytes()).send(); | |||
| new ParameterStatusResponse(output, "IntervalStyle".getBytes(), "iso_8601".getBytes()).send(); | |||
| new ParameterStatusResponse(output, "standard_conforming_strings".getBytes(), "true".getBytes()) | |||
| new ParameterStatusResponse(output, "standard_conforming_strings".getBytes(), "on".getBytes()) | |||
There was a problem hiding this comment.
| switch (this.statement.getResultType()) { | ||
| case UPDATE_COUNT: | ||
| case NO_RESULT: | ||
| new NoDataResponse(this.outputStream).send(); |
There was a problem hiding this comment.
PostgreSQL returns NoData as as response to a Describe Portal for an update count or other statement that does not return a result set.
| // Utility class for setting up test connection. | ||
| private RemoteSpannerHelper spannerHelper; | ||
|
|
There was a problem hiding this comment.
Removed, as it was never used
| public SpannerOptions spannerOptions() { | ||
| return options; | ||
| public Spanner getSpanner() { | ||
| if (spanner == null) { |
There was a problem hiding this comment.
Create a single shared Spanner instance instead of returning SpannerOptions. The Spanner instance is closed when the test environment is cleaned up.
| @@ -145,9 +145,9 @@ public void testBasicNoResultStatement() throws Exception { | |||
| Mockito.verify(statement, Mockito.times(1)) | |||
| .execute("UPDATE users SET name = someName WHERE id = -1"); | |||
| Assert.assertFalse(intermediateStatement.containsResultSet()); | |||
| Assert.assertEquals((int) intermediateStatement.getUpdateCount(), -2); | |||
There was a problem hiding this comment.
An actual update statement will never return -2 in real life.
…rser-update Update to parser.
…grade-jdbc-to-2.5.7-pg-SNAPSHOT deps: upgrade jdbc to 2.5.7-pg-SNAPSHOT
Adds integration tests that use the native PostgreSQL driver to connect to PGAdapter, and tweaks the protocol response from PGAdapter to be in line with what real PostgreSQL does. Notable changes to protocol: 1. standard_conforming_strings should return 'on' instead of 'true' 2. Describe Portal should respond with NoData if the portal does not contain any columns (i.e. it is an update count) This change also fixes a wrong assumption in IntermediateStatement that a zero update count means NO_RESULT. Zero update count means that no rows were updated/deleted by the UPDATE or DELETE statement.
|
Closing, replaced by #23 |
Adds integration tests that use the native PostgreSQL driver to connect
to PGAdapter, and tweaks the protocol response from PGAdapter to be in
line with what real PostgreSQL does. Notable changes to protocol:
contain any columns (i.e. it is an update count)
This change also fixes a wrong assumption in IntermediateStatement that
a zero update count means NO_RESULT. Zero update count means that no
rows were updated/deleted by the UPDATE or DELETE statement.