Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support UserContext in PreloadScripts #3072

Merged
merged 3 commits into from
Feb 5, 2025
Merged

feat: support UserContext in PreloadScripts #3072

merged 3 commits into from
Feb 5, 2025

Conversation

Lightning00Blade
Copy link
Collaborator

Need to add Unit tests mayble.

@Lightning00Blade Lightning00Blade added the update-expectations Update WPT expectations label Feb 4, 2025
@OrKoN OrKoN added the puppeteer Run Puppeteer test when added to PR label Feb 4, 2025
OrKoN
OrKoN reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we better refactor for clarify with this feature. I think current PR while working is a bit too confusing.

OrKoN
OrKoN approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, tests seem to be happy so let's land it

@Lightning00Blade
Copy link
Collaborator Author

Add interception seems to be slowed down I would want to fix that before we land.
Only on Mapper without ChromeDriver.

@Lightning00Blade Lightning00Blade merged commit dd2c9c0 into main Feb 5, 2025
53 checks passed
@Lightning00Blade Lightning00Blade deleted the fix-preload-scripts branch February 5, 2025 12:26
@release-please release-please bot mentioned this pull request Feb 5, 2025
Merged
@Lightning00Blade Lightning00Blade mentioned this pull request Feb 5, 2025
Closed
2 tasks
sadym-chromium pushed a commit that referenced this pull request Feb 6, 2025
@release-please
chore(main): release chromium-bidi 1.3.0 (#3049)
9afbab2 
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](chromium-bidi-v1.2.0...chromium-bidi-v1.3.0)
(2025-02-05)


### Features

* emit `browsingContext.navigationCommitted` event
([#3057](#3057))
([58be24c](58be24c))
* implement user context subscriptions
([#3039](#3039))
([7decf27](7decf27))
* support UserContext in PreloadScripts
([#3072](#3072))
([dd2c9c0](dd2c9c0))


### Bug Fixes

* group clicks in action
([#3052](#3052))
([c2d7fe3](c2d7fe3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
puppeteer Run Puppeteer test when added to PR update-expectations Update WPT expectations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lightning00Blade @OrKoN @browser-automation-bot