Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement user context subscriptions #3039

Merged
merged 3 commits into from
Jan 29, 2025
Merged

feat: implement user context subscriptions #3039

merged 3 commits into from
Jan 29, 2025

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jan 27, 2025 •
edited
Loading

  • Introduces UserContextStorage to abstract and re-use operations on user contexts. For now, only the get operation is moved.

Issue #2983

@OrKoN OrKoN force-pushed the orkon/user-context-subscription branch 3 times, most recently from 224ef9b to 9f90bbb Compare January 27, 2025 08:36
@OrKoN OrKoN mentioned this pull request Jan 27, 2025
Closed
2 tasks
@OrKoN OrKoN force-pushed the orkon/user-context-subscription branch from 53c7ba5 to dde1a3b Compare January 27, 2025 09:08
@OrKoN OrKoN marked this pull request as ready for review January 27, 2025 09:08
@OrKoN OrKoN requested a review from sadym-chromium January 27, 2025 09:08
@OrKoN OrKoN force-pushed the orkon/user-context-subscription branch from dde1a3b to 085ab17 Compare January 27, 2025 13:45
@OrKoN OrKoN enabled auto-merge (squash) January 27, 2025 15:26
sadym-chromium
sadym-chromium approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@sadym-chromium sadym-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general LGTM, but I have a few minor comments

@OrKoN OrKoN force-pushed the orkon/user-context-subscription branch from 92ee74e to 3e2e406 Compare January 29, 2025 07:03
@OrKoN OrKoN force-pushed the orkon/user-context-subscription branch from 3e2e406 to 49efdcb Compare January 29, 2025 07:22
@OrKoN OrKoN merged commit 7decf27 into main Jan 29, 2025
50 checks passed
@OrKoN OrKoN deleted the orkon/user-context-subscription branch January 29, 2025 08:20
@release-please release-please bot mentioned this pull request Jan 29, 2025
Merged
anshikavashistha pushed a commit to anshikavashistha/chromium-bidi that referenced this pull request Jan 31, 2025
@OrKoN @anshikavashistha
feat: implement user context subscriptions (GoogleChromeLabs#3039)
33c49cb 
- Introduces UserContextStorage to abstract and re-use operations on
user contexts. For now, only the get operation is moved.

Issue GoogleChromeLabs#2983
sadym-chromium pushed a commit that referenced this pull request Feb 6, 2025
@release-please
chore(main): release chromium-bidi 1.3.0 (#3049)
9afbab2 
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](chromium-bidi-v1.2.0...chromium-bidi-v1.3.0)
(2025-02-05)


### Features

* emit `browsingContext.navigationCommitted` event
([#3057](#3057))
([58be24c](58be24c))
* implement user context subscriptions
([#3039](#3039))
([7decf27](7decf27))
* support UserContext in PreloadScripts
([#3072](#3072))
([dd2c9c0](dd2c9c0))


### Bug Fixes

* group clicks in action
([#3052](#3052))
([c2d7fe3](c2d7fe3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadym-chromium sadym-chromium sadym-chromium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrKoN @sadym-chromium