fix: handle max depth property #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4931982 to
e8f28c6
Compare
e8f28c6 to
c4f276f
Compare
sadym-chromium
approved these changes
Jan 24, 2025
42a746c to
13db7ce
Compare
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 28, 2025
🤖 I have created a release *beep* *boop* --- ## [1.2.0](chromium-bidi-v1.1.0...chromium-bidi-v1.2.0) (2025-01-28) ### Features * implement unsubscribe by id ([#3013](#3013)) ([5f8752d](5f8752d)) ### Bug Fixes * allow `bluetooth.requestDevicePromptUpdated` subscription ([#3044](#3044)) ([dd4751d](dd4751d)) * fix unsubscribe by id parser ([#3034](#3034)) ([a51a55d](a51a55d)) * handle max depth property ([#3027](#3027)) ([1393215](1393215)) * rely on frameSubtreeWillBeDetached to emit contextDestroyed events ([#3029](#3029)) ([0d04e0b](0d04e0b)) * support correct to base64 for non-latin ([#3031](#3031)) ([6fe665f](6fe665f)), closes [#3019](#3019) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
anshikavashistha
pushed a commit
to anshikavashistha/chromium-bidi
that referenced
this pull request
Jan 31, 2025
According to the spec, max depth in browsingContext.contextDestroyed event should always be null. --------- Co-authored-by: browser-automation-bot <133232582+browser-automation-bot@users.noreply.github.com>
anshikavashistha
pushed a commit
to anshikavashistha/chromium-bidi
that referenced
this pull request
Jan 31, 2025
🤖 I have created a release *beep* *boop* --- ## [1.2.0](GoogleChromeLabs/chromium-bidi@chromium-bidi-v1.1.0...chromium-bidi-v1.2.0) (2025-01-28) ### Features * implement unsubscribe by id ([GoogleChromeLabs#3013](GoogleChromeLabs#3013)) ([5f8752d](GoogleChromeLabs@5f8752d)) ### Bug Fixes * allow `bluetooth.requestDevicePromptUpdated` subscription ([GoogleChromeLabs#3044](GoogleChromeLabs#3044)) ([dd4751d](GoogleChromeLabs@dd4751d)) * fix unsubscribe by id parser ([GoogleChromeLabs#3034](GoogleChromeLabs#3034)) ([a51a55d](GoogleChromeLabs@a51a55d)) * handle max depth property ([GoogleChromeLabs#3027](GoogleChromeLabs#3027)) ([1393215](GoogleChromeLabs@1393215)) * rely on frameSubtreeWillBeDetached to emit contextDestroyed events ([GoogleChromeLabs#3029](GoogleChromeLabs#3029)) ([0d04e0b](GoogleChromeLabs@0d04e0b)) * support correct to base64 for non-latin ([GoogleChromeLabs#3031](GoogleChromeLabs#3031)) ([6fe665f](GoogleChromeLabs@6fe665f)), closes [GoogleChromeLabs#3019](GoogleChromeLabs#3019) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, max depth in browsingContext.contextDestroyed event should always be null.