fix: rely on frameSubtreeWillBeDetached to emit contextDestroyed even…

…ts (GoogleChromeLabs#3029)

Co-authored-by: browser-automation-bot <133232582+browser-automation-bot@users.noreply.github.com>

src/bidiMapper/modules/cdp/CdpTargetManager.ts

@@ -116,10 +116,6 @@ export class CdpTargetManager {
       'Page.frameAttached',
       this.#handleFrameAttachedEvent.bind(this),
     );
-    cdpClient.on(
-      'Page.frameDetached',
-      this.#handleFrameDetachedEvent.bind(this),
-    );
     cdpClient.on(
       'Page.frameSubtreeWillBeDetached',
       this.#handleFrameSubtreeWillBeDetached.bind(this),
@@ -149,14 +145,6 @@ export class CdpTargetManager {
     }
   }
 
-  #handleFrameDetachedEvent(params: Protocol.Page.FrameDetachedEvent) {
-    // In case of OOPiF no need in deleting BrowsingContext.
-    if (params.reason === 'swap') {
-      return;
-    }
-    this.#browsingContextStorage.findContext(params.frameId)?.dispose(true);
-  }
-
   #handleFrameSubtreeWillBeDetached(
     params: Protocol.Page.FrameSubtreeWillBeDetachedEvent,
   ) {

src/bidiMapper/modules/context/BrowsingContextImpl.ts

@@ -202,7 +202,6 @@ export class BrowsingContextImpl {
 
   dispose(emitContextDestroyed: boolean) {
     this.#navigationTracker.dispose();
-    this.#deleteAllChildren();
 
     this.#realmStorage.deleteRealms({
       browsingContextId: this.id,
@@ -227,6 +226,9 @@ export class BrowsingContextImpl {
       );
     }
 
+    // Dispose children after the events are emitted.
+    this.#deleteAllChildren();
+
     this.#eventManager.clearBufferedEvents(this.id);
 
     this.#browsingContextStorage.deleteContextById(this.id);