Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes in new documentation #363

Merged
merged 7 commits into from
Apr 16, 2023
Merged

Minor fixes in new documentation #363

merged 7 commits into from
Apr 16, 2023

Conversation

rhugonnet
Copy link
Member

This PR:

  • Fixes the logo display on Firefox by using a PNG (couldn't find where the error originated using an SVG, despite digging quite deep...),
  • Fixes the _repr_html_ function in case self._out_shape is None

Resolves #362

@rhugonnet rhugonnet merged commit 998baa4 into GlacioHack:main Apr 16, 2023
@rhugonnet rhugonnet deleted the fix_doc branch April 16, 2023 22:58
@rhugonnet
Copy link
Member Author

Merging as it's only a couple lines + change from SVG to PNG, and our logo did not display otherwise in Firefox 😢

rhugonnet added a commit that referenced this pull request Apr 27, 2023
@adehecq @rhugonnet
Enable building the doc in offline formats #363 (#368)
c19ce4e 
* Increment to 0.0.7

* Enable building the doc in offline formats

* Fix typo

---------

Co-authored-by: Romain Hugonnet <romain.hugonnet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert default_mode of html_context to auto once Pydata Sphinx Theme is updated
1 participant
@rhugonnet