Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building the doc in offline formats #363 #368

Merged
merged 17 commits into from
Apr 27, 2023

Conversation

adehecq
Copy link
Member

@adehecq adehecq commented Apr 26, 2023

All in the title. Same as xdem PR 363.
Note: Ignore the 15 first commits, which are commits that diverged on my local fork.

@rhugonnet
Copy link
Member

rhugonnet commented Apr 26, 2023

You need to correct hmtlzip into htmlzip (I did it in xDEM in a separate PR, tests cannot cover RTD so it can only be checked manually on the RTD build)

@rhugonnet
Copy link
Member

Doing that to rerelease, see GlacioHack/xdem#361

@rhugonnet rhugonnet merged commit c19ce4e into GlacioHack:main Apr 27, 2023
@adehecq
Copy link
Member Author

adehecq commented Apr 27, 2023

You need to correct hmtlzip into htmlzip (I did it in xDEM in a separate PR, tests cannot cover RTD so it can only be checked manually on the RTD build)

Haha good catch ! I also just fixed the issue with my fork that diverged due to merges. So we could have actually closed this PR and I could have rewritten a new one.

@adehecq adehecq deleted the doc_pdf branch April 27, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants