Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 'Search GIPHY' #108

Closed
jetsekoopmans opened this issue Oct 6, 2020 · 7 comments
Closed

Translate 'Search GIPHY' #108

jetsekoopmans opened this issue Oct 6, 2020 · 7 comments

Comments

@jetsekoopmans
Copy link

GIPHY SDK Version: 2.0.3

Is is possible to translate the text in the search bar? It is now always 'Search GIPHY'.

@cgmaier
Copy link
Contributor

cgmaier commented Oct 6, 2020

hey @jetsekoopmans I will look into this and get back to ya soon! thanks

@PasqualePuzio
Copy link

Any news on this? Thanks

@VittoriDavide
Copy link

It'd be excellent to have this feature

@PasqualePuzio
Copy link

hey @jetsekoopmans I will look into this and get back to ya soon! thanks

@cgmaier is there a way to customize strings in GiphyViewController ?

Thanks

@cgmaier
Copy link
Contributor

cgmaier commented Nov 13, 2020

hey all, we've provided this option via a new property of GiphyViewController in v2.0.8

giphyViewController.placeholderText = "Search GIPHY"

@PasqualePuzio
Copy link

hey all, we've provided this option via a new property of GiphyViewController in v2.0.8

giphyViewController.placeholderText = "Search GIPHY"

Thank you very much for this new property. Very much appreciated.

What about the Select button in the confirmation page? Can that title be customized?

Thank you

@cgmaier
Copy link
Contributor

cgmaier commented Feb 4, 2021

hi @PasqualePuzio sorry for the very long delay on this. the latest release includes customization for this string
https://github.com/Giphy/giphy-ios-sdk-ui-example/releases/tag/v2.1.2

@cgmaier cgmaier closed this as completed Feb 4, 2021
djrluna pushed a commit that referenced this issue Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants