Merge pull request #108 from Giphy/task/improve-moat-logs

Task/improve moat logs
Giphy · Jan 31, 2020 · a7515be · a7515be
2 parents 3144c3a + e01a83d
commit a7515be
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/Sources/GiphyTracking.swift b/Sources/GiphyTracking.swift
@@ -72,7 +72,8 @@ extension GPHMedia {
             }
         } 
         guard let partner = GiphyCore.partner, let script = GiphyCore.omidJS, scripts.count > 0 else { return }
-        GiphyCore.log("OM:",bottleData?.tid ?? ""," creating and adding session")
+
+        GiphyCore.log("OM:",bottleData?.tid ?? ""," creating and adding session for ", self.type.rawValue)
 
         // setup context
         var _context: OMIDGiphyAdSessionContext?
@@ -104,6 +105,7 @@ extension GPHMedia {
 
 
         let adSession =  GPHAdSession(session: session)
+        adSession.mediaType = self.type
         adSession.tid = bottleData?.tid ?? ""
         GPHTrackingManager.adSessions[self] = adSession
         GiphyCore.log("OM:", bottleData?.tid ?? ""," session created successfully")
@@ -123,6 +125,7 @@ class GPHAdSession: NSObject {
     private var omSession: OMIDGiphyAdSession?
     var hasLoggedImpression: Bool = false
     var tid = ""
+    var mediaType: GPHMediaType = .gif
 
     weak var view: UIView? {
         didSet {
@@ -147,7 +150,6 @@ class GPHAdSession: NSObject {
         // add friendly obstruction views, like the ad pill
         for subview in mainAdView.subviews {
             if subview is GPHFriendlyObstructionView {
-                GiphyCore.log("OM:",tid," adding friendly obstruction view")
                 omSession?.addFriendlyObstruction(subview)
             }
         }
@@ -172,11 +174,11 @@ class GPHAdSession: NSObject {
             GiphyCore.log("OM: logging an impression failed:", error)
             return
         }
-        GiphyCore.log("OM:",tid," impression occured")
+        GiphyCore.log("OM:",tid," impression occured for: ", self.mediaType.rawValue)
     }
 
     func finish() {
-        GiphyCore.log("OM:",tid," finishing session")
+        GiphyCore.log("OM:",tid," finishing session for: ", self.mediaType.rawValue)
         omSession?.finish()
     }
 }