-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More specialized desktop and mobile layouts #228
Comments
Looks great so far! Here's a quick attempt at the desktop one (no breakpoints yet) (https://github.com/GeopJr/Tuba/tree/experiment/feat/redesign) The sidebar needs a complete re-write so I didn't bother for now (It's probably a bit early to ask but) should the top left sidebar button open the account switcher or the current users' profile and instead put the switcher in the menu next to it? should the scroll to top button switch to the left side? (it's removed in that branch) |
Nice, that's a great start! A few notes:
I pushed my initial mockup here, including a mobile layout: https://gitlab.gnome.org/Teams/Design/other-app-mockups/-/blob/master/tuba/tuba.png
I was thinking it'd open the account switcher, but good point about needing to have the link to your own profile somewhere. Maybe it's fine if that's available only from the account switcher?
I was thinking we could try having it be above the new post button.
Just home. Some open questions, mostly so I don't forget:
|
That's just using new widgets. Really don't do the new styles yet please, it's really hard to get it right without at least toolbar view and you will most likely get it wrong at least somewhere. :) Just keep the raised header, etc and switch over once the new widgets land - libadwaita demo is doing the same thing atm. |
Current state + some more questions: The compose button will follow the android behavior of 'hide on scroll down' and 'show on scroll up after some distance' (the scroll to top button relocates when the composer button gets revealed or hidden) In general:
On desktop:
On mobile: these are mostly additions to the open questions
Another pattern would be the Google Messages one of top left being the sidebar toggle and top right being the account switcher:
|
Maybe only for narrow window sizes?
How about moving them into Notifications? Just like there are Posts, Hashtags, News and For You in Discover or Accounts, Posts and Hashtags in Search.
I think so. That's what Files and Settings do and it can help find Tuba window among the others. |
I have some issues with nesting tabbed views (views with tabs like the main, explore or search one), it will look weird having two switchers for a single view: (quick edited screenshot mockups, the second switcher will be something else like "All" and "Mentions" for the notifications tab) |
So I'm using Tuba with two accounts that are both bugaevc@some.domain, and it ellipsizes before the domain name! Given that I have the same avatar on both, I can't distinguish between them at all. So something should definitely be done about this. That being said letting it break into multiple lines also looks bad. Could the account switcher perhaps be a popover that's be wider than the sidebar? |
On desktop, yes but on mobile the double switchers cannot be avoided (since on mobile Notifications and Conversations are no longer on the sidebar but instead on a switcher)
My initial question was mostly about the posts on a timeline (where impersonation can happen by ellipsizing the handle). On the account switcher I think the stack looks better than a popover but it would match Fractal. I think ellipsizing is somewhat needed even on the popover for extra long domains. |
This is looking great, can't wait for this to land! Is there a branch to try the current state?
I think you get the new home icon for free when adwaita icon theme updates
This seems separate from the navigation changes, so I'd split it out to its own issue
Move to the headerbar in which cases? For now I think it's fine to keep them in the sidebar, I think.
No strong opinion, feel free to keep it for now.
Hmm? Which entries are moving to the primary menu?
For now I'd try the following as a next step:
For the account switcher a popover would be the more standard pattern, and it'd cleanly solve the truncation issue. It'd be good to have some kind of inline check to indicate which account is selected when there's more than one, but that's a separate issue :) |
feat/sidebar/match-moockup-order |
Sounds good, they weren't in the mockup (not sure if they were in a release then so that checks out) so I assumed they were hidden
All of them (sidebar items) I assume, on mobile, according to the original post "On mobile it's weird to have a huge sidebar for what would otherwise be a normal primary menu"
I'll follow Fractal's design then! |
Yeah, IMO the current version is more or less ready for a 45 release. I'd still be interested in trying the no-sidebar thing on mobile, but it's a bit experimental to have so much navigation inside the primary menu so it might not work out :) The 3 dot menu and time unit thing are not essential and can be discussed separately / after the next release. |
Hey! Sorry for reviving this old issue, but may I ask how's the layout chosen? On Plasma Mobile, the PC layout seems to be used even with a screen resolution that should be used for mobile. I'm on postmarketOS on qemu, using the flatpak tuba. Maybe a setting or command-line flag to force either layout would be nice to add? Edit: Nevermind, I installed phosh and now it works (on plasma). If phosh is installed (even if not used) it works (both apk and flatpak) with the correct layout. |
Did this happen with other libadwaita apps (prior to your workaround)? FWIW, the layout is based on the window size (for all libadwaita apps that are convergent) |
Haven’t tried any other adwaita apps on kde tbh, but I can try and let you know (also the desktop layout looks really good (on desktop), congrats! (it’s not common to even have a desktop layout on gtk apps these days so tuba really impressed me))
Ye, I’ll also report to plstmarketOS the lack of libGLESv2 as a dependency of tuba in their apk repos I’ll do some more testing to try to figure out exactly what fixed the layout problem (libGLESv2 or something else that came with phosh) and report back. |
I suspect this is the same issue as https://gitlab.gnome.org/GNOME/libadwaita/-/issues/809. The person there clearly has unset gtk-xft-dpi (and everything else as well, hence aliased text), so settings portal doesn't provide it. Breakpoint conditions in most apps do account for it too (that's what Now, settings for this kind of stuff were never standardized, and xdg-desktop-portal-gtk/gnome do expose the needed keys, but -kde? It doesn't. And I suspect it also has keys that -gtk/-gnome don't expose. So you need to have xdg-desktop-portal-gtk. But that's not enough. Before the switch to portals.conf that was it, but now gtk also needs to be listed there alongside kde. GNOME's config does this, but KDE's apparently doesn't (and why would it?) TLDR this part of portals was never really properly designed and we're seeing it explode now :( I can add a workaround to libadwaita to have it treat gtk-xft-dpi=0 as default value, like gtk does for text, but it will still be fundamentally broken... |
The navigation model is currently not ideal on either desktop or mobile:
Using the new AdwBreakpoints it should be possible to have independent layouts for the two cases, which would help improve the layout for both. Here's a strawman proposal:
The Elk sidebar is a good example of what I have in mind for the desktop layout, it'd also be nice to separate the less important items (Explore, Local, Federated) in a separate section below the main section:
The text was updated successfully, but these errors were encountered: