Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sidebar is too narrow → truncated strings #401

Closed
rene-coty opened this issue Jul 21, 2023 · 2 comments · Fixed by #403
Closed

[Bug]: Sidebar is too narrow → truncated strings #401

rene-coty opened this issue Jul 21, 2023 · 2 comments · Fixed by #403
Labels
bug Something isn't working designer input needed

Comments

@rene-coty
Copy link
Contributor

Describe the bug

With the new design changes in 0.4 the sidebar has been decreased, but this results in some strings being truncated. A cursor is shown to view the entire strings but this makes the UI not very pleasant at all (it sometimes feels buggy)..
Given the fact that the sidebar can't be resized, the solution would be to make its size adapt to the length of the strings it displays to avoid truncated translated strings

Eventually I could reduce the length of the string by choosing an equivalent, but that would only be a partial and temporary fix (strings could still be truncated in other languages) + I'm following Mastodon's guidelines so this would only harm the quality of translations..

Steps To Reproduce

  1. Open app with French as locale
  2. View sidebar: "Demandes d'abonnement" (Folow Requests)

Logs and/or Screenshots

Kooha-2023-07-21-11-32-54.webm

Instance Backend

Mastodon

Operating System

Fedora 38

Package

Flatpak

Troubleshooting information

os: GNOME 44 (Flatpak runtime)
prefix: /app
flatpak: true
version: 0.4.0 (production)
gtk: 4.10.3 (4.10.3)
libadwaita: 1.3.2 (1.3.2)
libsoup: 3.4.2 (3.4.2)
libgtksourceview: 5.8.0 (5.8.0)

Additional Context

No response

@rene-coty rene-coty added the bug Something isn't working label Jul 21, 2023
@GeopJr
Copy link
Owner

GeopJr commented Jul 21, 2023

Thanks for raising this issue!

Continuing from here: #273 (comment)

The solutions are either replacing the label with just "Requests" (or maybe "Invites"?) or ellipsizing it.

As for the concerns about the width of the sidebar, it's temporary until #228. Follow Requests will probably move to the headerbar menu

cc: @bertob

@bertob
Copy link
Contributor

bertob commented Jul 21, 2023

Since all the other strings fit just fine I wouldn't increase the width of the entire panel for this one string (that is rarely used, even). Shortening the string seems like the cleanest solution, but regardless of that the sidebar should never scroll horizontally, so I'd make it truncate strings independently of other things we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working designer input needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants