ColorToVector : Fix parameter types #5653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to get 👀 on this please @danieldresser-ie. |
|
Sorry I missed this. LGTM ... aside from the whitespace checker disliking the .gfr file. It seems bad that our formatting checker doesn't like how we save .gfr scripts? |
Arguably this should be provided by PyImath, but it isn't currently. We need it for the next commit.
They were the wrong way round.
ca6c566 to
4492c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes Geoff's fix from #5650 and fixes the knock-on backwards compatibility problems it causes, adding a unit test to be sure all is well.