Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorToVector.osl - fix parameter types #5650

Closed
wants to merge 2 commits into from

Conversation

geoffpedder
Copy link
Contributor

The input and output types were opposite of what this conversion shader does, i flipped them around so the input is a color and the output is a vector

@johnhaddon
Copy link
Member

Thanks @geoffpedder! Do you want this to go into a 1.3.x release, or is it OK in 1.4 (which is what main will become)?

I think we have a bit of additional work to do before we can merge this, since old files will have setValue( V3f() ) in them, and the new colour plugs won't accept that. Should be easy enough to add a conversion though - if you're interested I can point you in the right direction, or I can bash it out myself if you prefer.

@geoffpedder
Copy link
Contributor Author

I think it's ok to wait until 1.4 as it still works as is. I had a feeling old scenes might be a problem. Maybe it's better if I let you handle that part. Thanks John!

@johnhaddon
Copy link
Member

I had a feeling old scenes might be a problem. Maybe it's better if I let you handle that part.

I've dealt with that in #5653, which includes your original commit from this PR. Closing this one now in favour of that one...

@johnhaddon johnhaddon closed this Feb 1, 2024
@johnhaddon
Copy link
Member

Thanks Geoff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants