Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup proxy configuration #1440

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Setup proxy configuration #1440

merged 4 commits into from
Oct 9, 2024

Conversation

danivovich
Copy link
Contributor

@danivovich danivovich commented Oct 2, 2024 •
edited
Loading

Description

Set the ability to define the local proxy sidecar for Finch to use. The proxy configuration is managed via the platform repo.

Related Issues

#1437

Changes Made

  • SMTP stream config
  • Finch genserver config
  • Reasonable fallbacks for local development

Screenshots (if applicable)

N/A

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • [ ] New functionality is tested and all tests are green
  • [ ] I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • [ ] If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • [ ] If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.

@danivovich danivovich added this to the Sprint 10/08/24 milestone Oct 2, 2024
@danivovich danivovich self-assigned this Oct 2, 2024
@danivovich danivovich linked an issue Oct 2, 2024 that may be closed by this pull request
Egress Proxy for the Phoenix app #1437
Closed
5 tasks
@danivovich
Cache busting
4b12639
@danivovich
Tweaks
db2b3eb 
- Remove generic build and deps cache to keep dev and eval-main from
  conflicting
- Fix errand , in application file
@danivovich
Update documentation for proxy changes
440dd8e
@danivovich danivovich merged commit 7393d6d into eval-main Oct 9, 2024
2 checks passed
@danivovich danivovich deleted the proxy-setup branch October 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrug kkrug kkrug approved these changes

@stepchud stepchud Awaiting requested review from stepchud

@jdonis jdonis Awaiting requested review from jdonis

Assignees

@danivovich danivovich

Labels
None yet
Projects
None yet
Milestone
Sprint 10/08/24
Development

Successfully merging this pull request may close these issues.

Egress Proxy for the Phoenix app
2 participants
@danivovich @kkrug