Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #351 #352

Merged
merged 1 commit into from
May 1, 2020
Merged

fixes #351 #352

merged 1 commit into from
May 1, 2020

Conversation

bena-nasa
Copy link
Collaborator

Fixes issue #351

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • [ X] I have tested this change with a run of GEOSgcm (if non-trivial)
  • [X ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa requested a review from a team as a code owner May 1, 2020 15:39
@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug! labels May 1, 2020
atrayano
atrayano approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@atrayano atrayano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@atrayano atrayano merged commit 97cf331 into develop May 1, 2020
@bena-nasa bena-nasa mentioned this pull request May 1, 2020
Closed
@tclune tclune deleted the bmauer/fixes#351 branch May 21, 2020 13:35
This was referenced May 3, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrayano atrayano atrayano approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bena-nasa @atrayano