Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1495. Correct ESMF errors with monthly collections #1496

Merged
merged 1 commit into from
May 3, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented May 3, 2022

Description

Following #352, we use a "start time" with any frequency that could be divided by. In some places, we remove the calendar specification because specifying a starttime provides the calendar for ESMF.

Related Issue

Closes #1495

Motivation and Context

Cleans out some ESMF errors.

How Has This Been Tested?

I ran a two-month run of GEOS so I could get a full month of output (my restarts start on the 14th). The two-month runs are identical and no ESMF errors were output.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels May 3, 2022
@mathomp4 mathomp4 self-assigned this May 3, 2022
@mathomp4
Copy link
Member Author

mathomp4 commented May 3, 2022

Well, this seems to work. To wit:

$ cmpnc4 stock-2022May03-2month-c24/scratch/stock-2022May03-2month-c24.geosgcm_moist.20000501_0000z.nc4 mapldev-2022May03-2month-c24-ESMFerrorfix/scratch/mapldev-2022May03-2month-c24-ESMFerrorfix.geosg
cm_moist.20000501_0000z.nc4
DIFFER : LENGTHS OF GLOBAL ATTRIBUTE : Source : 58 <> 73 : VALUES : GEOSgcm-v10.22.1 experiment_id: stock-2022May03-2month-c24 <> GEOSgcm-v10.22.1 experiment_id: mapldev-2022May03-2month-c24-ESMFerrorfix
DIFFER : LENGTHS OF GLOBAL ATTRIBUTE : Title : 26 <> 41 : VALUES : stock-2022May03-2month-c24 <> mapldev-2022May03-2month-c24-ESMFerrorfix

If we ignore the global metadata:

$ nccmp -dmfsB stock-2022May03-2month-c24/scratch/stock-2022May03-2month-c24.geosgcm_moist.20000501_0000z.nc4 mapldev-2022May03-2month-c24-ESMFerrorfix/scratch/mapldev-2022May03-2month-c24-ESMFerrorfix.geosgcm_moist.20000501_0000z.nc4
Files "stock-2022May03-2month-c24/scratch/stock-2022May03-2month-c24.geosgcm_moist.20000501_0000z.nc4" and "mapldev-2022May03-2month-c24-ESMFerrorfix/scratch/mapldev-2022May03-2month-c24-ESMFerrorfix.geosgcm_moist.20000501_0000z.nc4" are identical.

And the partials are identical too:

$ nccmp -dmfsB stock-2022May03-2month-c24/scratch/stock-2022May03-2month-c24.geosgcm_moist.20000401_0000z.nc4-partial mapldev-2022May03-2month-c24-ESMFerrorfix/scratch/mapldev-2022May03-2month-c24-ESMFerrorfix.geosgcm_moist.20000401_0000z.nc4-partial
Files "stock-2022May03-2month-c24/scratch/stock-2022May03-2month-c24.geosgcm_moist.20000401_0000z.nc4-partial" and "mapldev-2022May03-2month-c24-ESMFerrorfix/scratch/mapldev-2022May03-2month-c24-ESMFerrorfix.geosgcm_moist.20000401_0000z.nc4-partial" are identical.

@mathomp4 mathomp4 marked this pull request as ready for review May 3, 2022 18:30
@mathomp4 mathomp4 requested a review from a team as a code owner May 3, 2022 18:30
@mathomp4 mathomp4 linked an issue May 3, 2022 that may be closed by this pull request
@atrayano atrayano merged commit 3935e46 into develop May 3, 2022
@mathomp4 mathomp4 deleted the bugfix/mathomp4/1495-monthly-esmf-errors branch May 3, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESMF Errors emitted with monthly history collections
2 participants