-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACG Rebuild Issue again in GEOS: datasea (and Ocean?) #1912
Comments
Okay. I think I know the issue. If we look, per the CMake code, it is saying the files generated will be:
but the files we make are:
So, the CMake thinks we'll make I'm pretty sure this is my fault. Before the ocean ACG code, we "accidentally" used similar names for both the component (aka
So what my code in #1448 does is essentially go off of the component name and use that to construct what we think the ACG will make. That is dumb. The Python ACG DOES NOT CARE about the component! All it takes is the StateSpecs file and removes @sanAkel and @darianboggs have the file:
which is a good file and it works, but the CMake code is dumb and assumed the StateSpecs file would be called We just need to do the same algorithm in CMake that Python does in the ACG. I can code this up! |
What do you mean by
Indeed I have it this way:
But I really do not have |
…cmake Fixes #1912. Fixes for ACG Cmake code
This is a bit of a repeat of the issue solved by #1448. In doing some GOCART tests today, I notice that if you do a no-op rebuild of GEOS you get:
I mean, I didn't go near datasea. But that is a component that @sanAkel worked with @darianboggs on using the ACG. So something is a bit wonky. Thing is datasea calls the ACG:
mapl_acg (${this} GEOS_DataSea_StateSpecs.rc IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS GET_POINTERS DECLARE_POINTERS)
the same as, say, dust:
mapl_acg (${this} DU2G_StateSpecs.rc IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS GET_POINTERS DECLARE_POINTERS)
Thus I suspect the issue is with the CMake macro/function in MAPL.
The text was updated successfully, but these errors were encountered: