Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with calling ACG multiple times #1448

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 21, 2022

Description

This PR makes some changes to the cmake custom command that invokes the Python ACG to alleviate the no-op rebuilds of GOCART2G (see GEOS-ESM/GOCART#117)

Thanks to help from @tclune, this now should fix that issue.

Related Issue

GEOS-ESM/GOCART#117

Motivation and Context

Makes the build more efficient.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 21, 2022
@mathomp4 mathomp4 self-assigned this Mar 21, 2022
@tclune
Copy link
Collaborator

tclune commented Mar 21, 2022

Correction - the PR makes changes to the CMake ACG custom command. ACG itself is unchanged. I'll edit the PR.

@mathomp4 mathomp4 marked this pull request as ready for review March 21, 2022 19:06
@mathomp4 mathomp4 requested review from a team as code owners March 21, 2022 19:06
@mathomp4
Copy link
Member Author

Correction - the PR makes changes to the CMake ACG custom command. ACG itself is unchanged. I'll edit the PR.

Ah. Yeah. My bad :)

@mathomp4
Copy link
Member Author

Testing shows this is zero-diff, so we should be safe.

@mathomp4
Copy link
Member Author

Oh, and I fixed up a bit of old-style CMake I saw in here.

@mathomp4 mathomp4 merged commit 414e90f into develop Mar 22, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/fix-acg-multicompile branch March 22, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants