Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing evaluate_consensus's extract_answer_fn typing #213

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Fixing evaluate_consensus's extract_answer_fn typing #213

merged 1 commit into from
Jan 18, 2025

Conversation

jamesbraza
Copy link
Collaborator

When you type it correctly, there's no need for cast

@jamesbraza jamesbraza added the bug Something isn't working label Jan 18, 2025
@jamesbraza jamesbraza requested review from sidnarayanan and a team January 18, 2025 02:40
@jamesbraza jamesbraza self-assigned this Jan 18, 2025
@jamesbraza jamesbraza mentioned this pull request Jan 18, 2025
Merged
@ludomitch
Copy link
Contributor

I really dislike casting to satisfy mypy so this makes me very happy

@jamesbraza jamesbraza merged commit 13c13cc into main Jan 18, 2025
6 checks passed
@jamesbraza jamesbraza deleted the fixing-extract-answer-typing branch January 18, 2025 20:17
@jamesbraza jamesbraza mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidnarayanan sidnarayanan sidnarayanan approved these changes

@ludomitch ludomitch ludomitch approved these changes

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesbraza @ludomitch @sidnarayanan