Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consensus sampling decomposition and per-group standard error #211

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Consensus sampling decomposition and per-group standard error #211

merged 9 commits into from
Jan 20, 2025

Conversation

jamesbraza
Copy link
Collaborator

  • Decomposes evaluate_consensus to operate per-group a free function
  • Adds support for binomial standard error on a per-group basis
  • Removed num_samples bad default of 1
  • Added more docs/code comments in the docstring

@jamesbraza jamesbraza added the enhancement New feature or request label Jan 16, 2025
@jamesbraza jamesbraza requested review from whitead, sidnarayanan, Ryan-Rhys and a team January 16, 2025 00:57
@jamesbraza jamesbraza self-assigned this Jan 16, 2025
@jamesbraza jamesbraza mentioned this pull request Jan 16, 2025
Closed
ludomitch
ludomitch reviewed Jan 17, 2025
View reviewed changes
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
sidnarayanan
sidnarayanan reviewed Jan 17, 2025
View reviewed changes
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
@jamesbraza jamesbraza force-pushed the no-group-consensus-std-err branch from 4beed33 to 5fcc294 Compare January 18, 2025 09:03
@jamesbraza jamesbraza requested a review from ludomitch January 18, 2025 09:04
sidnarayanan
sidnarayanan reviewed Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@sidnarayanan sidnarayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving just yet - I have a concern about the sampling-with-replacement part of the code.

ldp/alg/algorithms.py Outdated Show resolved Hide resolved
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
sidnarayanan
sidnarayanan reviewed Jan 18, 2025
View reviewed changes
ldp/alg/algorithms.py Outdated Show resolved Hide resolved
@jamesbraza jamesbraza force-pushed the no-group-consensus-std-err branch from 5fcc294 to 5a49c63 Compare January 18, 2025 20:27
@jamesbraza jamesbraza force-pushed the no-group-consensus-std-err branch 2 times, most recently from 2c7718f to 4565a2b Compare January 20, 2025 19:49
@jamesbraza jamesbraza force-pushed the no-group-consensus-std-err branch from 4565a2b to 445f391 Compare January 20, 2025 19:54
@jamesbraza
Copy link
Collaborator Author

Gonna merge, @sidnarayanan feel free to make other comments and I will get back to them

@jamesbraza jamesbraza merged commit 6cf9e66 into main Jan 20, 2025
6 checks passed
@jamesbraza jamesbraza deleted the no-group-consensus-std-err branch January 20, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludomitch ludomitch ludomitch approved these changes

@whitead whitead Awaiting requested review from whitead

@Ryan-Rhys Ryan-Rhys Awaiting requested review from Ryan-Rhys

@sidnarayanan sidnarayanan Awaiting requested review from sidnarayanan

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesbraza @sidnarayanan @ludomitch