-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add browser testing infrastructure #2378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launchTestNode
9ed19bd
to
a6c5d8d
Compare
nedsalk
commented
Jun 18, 2024
arboleya
previously approved these changes
Jun 23, 2024
packages/account/src/test-utils/setup-test-provider-and-wallets.ts
Outdated
Show resolved
Hide resolved
packages/account/src/test-utils/setup-test-provider-and-wallets.ts
Outdated
Show resolved
Hide resolved
arboleya
approved these changes
Jun 23, 2024
petertonysmith94
approved these changes
Jun 24, 2024
danielbate
approved these changes
Jun 24, 2024
Coverage Report:
Changed Files:
|
maschad
approved these changes
Jun 24, 2024
petertonysmith94
added a commit
that referenced
this pull request
Jun 25, 2024
This reverts commit 04b58e2.
petertonysmith94
added a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge shoutout to @danielbate with whom I had multiple discussions and debugging sessions to get this working!
The idea is to run an http server that has the responsibility of launching and killing
fuel-core
nodes and the functionality would be transparent tolaunchTestNode
, meaning all the @group node tests that uselaunchTestNode
can be reused for@group browser
tests as well.This is achieved by setting an environment variable based on which the internals of
launchTestNode
/setupTestProviderAndWallets
either uselaunchNode
(in node tests) or send requests to the http server (browser tests).I'll write documentation for the utility once we dogfood this in our whole test suite and verify everything works as expected. We might also put it behind a
fuels
cli command, but I'd also rather do that when we want to make this generally available.closes #284, #2178