Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make launchTestNode utility compatible with browser testing #2178

Closed
nedsalk opened this issue Apr 26, 2024 · 0 comments · Fixed by #2378
Closed

Make launchTestNode utility compatible with browser testing #2178

nedsalk opened this issue Apr 26, 2024 · 0 comments · Fixed by #2378
Assignees
Labels
feat Issue is a feature
Milestone

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Apr 26, 2024

launchTestNode depends on launchNode, which depends on node and so cannot run in browser tests.

A possible solution could be to start a web server in the global test setup and have launchNode somehow interact with it, while keeping in mind that launchNode has to be able to run standalone as well.

@nedsalk nedsalk added feat Issue is a feature blocked labels Apr 26, 2024
@nedsalk nedsalk self-assigned this Apr 26, 2024
@nedsalk nedsalk removed the blocked label Jun 7, 2024
@arboleya arboleya added the p1 label Jun 9, 2024
@arboleya arboleya modified the milestones: Caterpillar, Mainnet Jun 9, 2024
@nedsalk nedsalk linked a pull request Jun 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants