feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1 #2416

rymnc · 2024-10-31T05:04:48Z

Note

Some values for the tests need expert opinion from @MitchTurner. A follow up PR will be created to define the UninitializedTask that wraps over this task.

Linked Issues/PRs

part of #2140, but doesn't close it yet.

Description

We define a new RunnableTask, GasPriceServiceV1, which uses the da block cost source in tandem with the l2 block source
Tests for the same
Casts to and from the v1 algorithm updater
we take a direct dependency on v0's metadata so that we can migrate between the two.

Checklist

Breaking changes are clearly marked as such in the PR description and changelog
New behavior is reflected in tests
The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

I have reviewed the code myself
I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

Rust SDK
Sway compiler
Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
Someone else?

rymnc · 2024-10-31T09:16:10Z

crates/services/gas_price_service/src/v1/service.rs

+    }
+
+    #[tokio::test]
+    async fn run__updates_gas_price_with_da_block_cost_source() {


cc: @MitchTurner this test seems to be failing with the following error -

called `Result::unwrap()` on an `Err` value: L2 block expected but not found in unrecorded blocks: 1

which i narrowed down to

fuel-core/crates/fuel-gas-price-algorithm/src/v1.rs

Lines 546 to 562 in a14922e

fn drain_l2_block_bytes_for_range(

&mut self,

height_range: Range<u32>,

) -> Result<u128, Error> {

let mut total: u128 = 0;

for expected_height in height_range {

let (actual_height, bytes) = self

.unrecorded_blocks

.pop_first()

.ok_or(Error::L2BlockExpectedNotFound(expected_height))?;

if actual_height != expected_height {

return Err(Error::L2BlockExpectedNotFound(expected_height));

}

total = total.saturating_add(bytes as u128);

}

Ok(total)

}

.

This is what happens when the da block cost that is received refers to an L2 block that hasn't been processed by the algorithm yet. that is fine, seems like defined behaviour.

Below, on line 432-434, I define the cost and bytes. Something seems to be wrong in the drain_l2_block_bytes_for_range function

fuel-core/crates/fuel-gas-price-algorithm/src/v1.rs

Line 546 in a14922e

fn drain_l2_block_bytes_for_range(

when I call it with just one item in the range. because the range_bytes it yields after being called in

fuel-core/crates/fuel-gas-price-algorithm/src/v1.rs

Line 529 in a14922e

let range_bytes = self.drain_l2_block_bytes_for_range(height_range)?;

is 0, which doesn't seem too correct.

wondering if you have any thoughts about the params I'm using.

I think we discussed this offline someplace, but I'll record it here.

This is what happens when the da block cost that is received refers to an L2 block that hasn't been processed by the algorithm yet. that is fine, seems like defined behaviour.

We should always receive DA recorded blocks after L2 blocks. This is because we can't commit a block to DA until after it is produced on L2.

when I call it with just one item in the range. because the range_bytes it yields after being called in

Good catch. I've changed the behavior anyway in this pr: #2415

Should solve it.

wondering if you have any thoughts about the params I'm using.

With these tests, the values don't exactly matter. We use an assert_ne! and as long as that's true we're not concerned with the details. The problem with this approach is the test writer/reader still needs to know what values would result in a different gas price. This is part of the reason I originally had an abstraction of gas price updater (which we've (you've) removed)

MitchTurner · 2024-11-09T05:35:46Z

crates/services/gas_price_service/src/v1/da_source_service/block_committer_costs.rs

    /// The range of blocks that the costs apply to
-    pub blocks_range: core::ops::Range<u64>,
+    pub blocks_range: core::ops::Range<u32>,


We'll need to change this to just be a vec with these changes:
#2415

MitchTurner · 2024-11-09T05:44:44Z

crates/services/gas_price_service/src/v1/da_source_service/block_committer_costs.rs

            // arbitrary logic to generate a new value
            let mut value = self.value.clone();
            if let Some(value) = &mut value {
                value.sequence_number = seq_no;
                value.blocks_range =
                    value.blocks_range.end * seq_no..value.blocks_range.end * seq_no + 10;
-                value.da_block_height = value.da_block_height + (seq_no + 1).into();
+                value.da_block_height =
+                    value.da_block_height + ((seq_no + 1) as u64).into();
                value.total_cost += 1;
                value.total_size_bytes += 1;
            }


There is a lot of unchecked arithmetic and casting going on here. How do you feel about switching to checked and into/from here?

MitchTurner · 2024-11-10T04:34:23Z

crates/services/gas_price_service/src/v1/service.rs

+    }
+
+    #[tokio::test]
+    async fn run__updates_gas_price_with_da_block_cost_source() {


I think we discussed this offline someplace, but I'll record it here.

This is what happens when the da block cost that is received refers to an L2 block that hasn't been processed by the algorithm yet. that is fine, seems like defined behaviour.

We should always receive DA recorded blocks after L2 blocks. This is because we can't commit a block to DA until after it is produced on L2.

when I call it with just one item in the range. because the range_bytes it yields after being called in

Good catch. I've changed the behavior anyway in this pr: #2415

Should solve it.

MitchTurner · 2024-11-10T06:01:35Z

crates/services/gas_price_service/src/v1/service.rs

+    }
+
+    #[tokio::test]
+    async fn run__updates_gas_price_with_da_block_cost_source() {


wondering if you have any thoughts about the params I'm using.

With these tests, the values don't exactly matter. We use an assert_ne! and as long as that's true we're not concerned with the details. The problem with this approach is the test writer/reader still needs to know what values would result in a different gas price. This is part of the reason I originally had an abstraction of gas price updater (which we've (you've) removed)

MitchTurner · 2024-11-10T06:20:44Z

crates/services/gas_price_service/src/v1/service.rs

+
+        // when
+        service.run(&mut watcher).await.unwrap();
+        l2_block_sender.send(l2_block).await.unwrap();


Is the bug you're seeing the reason we aren't submitting a new DA block here?

not seeing the bug anymore :)

I think this test should be "sending" a block to the DA record service, not the l2_block_sender.

I still need to trigger update_da_gas_price(), so I've added it in the update_da_record_data fn of the AlgorithmV1 impl in c516ea9

crates/services/gas_price_service/src/v1/service.rs

MitchTurner · 2024-11-13T08:46:06Z

crates/services/gas_price_service/src/v1/da_source_service/service.rs

@@ -103,12 +104,14 @@ where
    async fn run(&mut self, state_watcher: &mut StateWatcher) -> Result<bool> {
        let continue_running;

+        let tick: BoxFuture<tokio::time::Instant> = Box::pin(self.poll_interval.tick());


Why do we need the BoxFuture? I ran it on my machine without and it compiled.

you're right, I had it that way when i was testing something. removed in 53291a5

MitchTurner · 2024-11-13T08:55:17Z

crates/fuel-gas-price-algorithm/src/v1.rs

@@ -313,6 +313,7 @@ impl AlgorithmUpdaterV1 {
        if !height_range.is_empty() {
            self.da_block_update(height_range, range_cost)?;
            self.recalculate_projected_cost();
+            self.update_da_gas_price();


Ah. Haha. I get it now... I think it makes sense either way but this probably better.

Probably should have some tests in the algo for this.

addressed in 8ae983f

MitchTurner · 2024-11-13T09:00:50Z

crates/services/gas_price_service/src/v1/metadata.rs

+    pub capped_range_size: u16,
+    pub decrease_range_size: u16,
+    pub block_activity_threshold: u8,
+    pub unrecorded_blocks: Vec<(u32, u64)>,


Hmm. I guess it doesn't hurt. I don't know why we'd need this if it wasn't already in the metadata.

need this to bootstrap the AlgorithmV1 with a state that we can test only DA data being sent :)

Hmm. K. Technically you could provide a metadata with it, but that's expensive.

MitchTurner · 2024-11-13T09:19:28Z

crates/services/gas_price_service/src/v1/service.rs

+        if let Ok(v1_metadata) = V1Metadata::try_from(updater_metadata.clone()) {
+            algorithm_updater = v1_algorithm_from_metadata(v1_metadata, config);
+        } else {
+            let v0_metadata = V0Metadata::try_from(updater_metadata).map_err(|_| {
+                crate::common::utils::Error::CouldNotInitUpdater(anyhow::anyhow!(
+                    "Could not convert metadata to V0Metadata"
+                ))
+            })?;
+            let v1_metadata = V1Metadata::construct_from_v0_metadata(v0_metadata, config)
+                .map_err(|err| {
+                    crate::common::utils::Error::CouldNotInitUpdater(anyhow::anyhow!(err))
+                })?;
+            algorithm_updater = v1_algorithm_from_metadata(v1_metadata, config);
+        }


nit: I think we should just unify this branch and add a method fn best_v1_metadata(metadata: &Metadata, config: &V1AlgorithmConfig). In both branches we end up calling v1_algorithm_from_metadata, so something like:

Suggested change

if let Ok(v1_metadata) = V1Metadata::try_from(updater_metadata.clone()) {

algorithm_updater = v1_algorithm_from_metadata(v1_metadata, config);

} else {

let v0_metadata = V0Metadata::try_from(updater_metadata).map_err(|_| {

crate::common::utils::Error::CouldNotInitUpdater(anyhow::anyhow!(

"Could not convert metadata to V0Metadata"

))

})?;

let v1_metadata = V1Metadata::construct_from_v0_metadata(v0_metadata, config)

.map_err(|err| {

crate::common::utils::Error::CouldNotInitUpdater(anyhow::anyhow!(err))

})?;

algorithm_updater = v1_algorithm_from_metadata(v1_metadata, config);

}

let v1_metadata = best_v1_metadata(updater_metadata, config)?;

algorithm_updater = v1_algorithm_from_metadata(v1_metadata, config);

addressed in 2291207

MitchTurner · 2024-11-14T06:59:08Z

crates/fuel-gas-price-algorithm/src/v1/tests/update_da_record_data_tests.rs

+
+    // then
+    let new_da_gas_price = updater.new_scaled_da_gas_price;
+    assert_ne!(old_da_gas_price, new_da_gas_price);


We should be more specific at this level (and not just say it is different) You can copy most of the code from
update_l2_block_data__below_threshold_will_decrease_exec_gas_price, update_l2_block_data__above_threshold_will_increase_exec_gas_price, and update_l2_block_data__even_threshold_will_not_change_exec_gas_price

It feels redundant, but they are different endpoints so they change independently.

AurelienFT

The code looks clean and understandable from an external POV.

@acerone85

## Version v0.41.0 ### Added - [2547](#2547): Replace the old Graphql gas price provider adapter with the ArcGasPriceEstimate. - [2445](#2445): Added GQL endpoint for querying asset details. - [2442](#2442): Add uninitialized task for V1 gas price service - [2154](#2154): Added `Unknown` variant to `ConsensusParameters` graphql queries - [2154](#2154): Added `Unknown` variant to `Block` graphql queries - [2154](#2154): Added `TransactionType` type in `fuel-client` - [2321](#2321): New metrics for the TxPool: - The size of transactions in the txpool (`txpool_tx_size`) - The time spent by a transaction in the txpool in seconds (`txpool_tx_time_in_txpool_seconds`) - The number of transactions in the txpool (`txpool_number_of_transactions`) - The number of transactions pending verification before entering the txpool (`txpool_number_of_transactions_pending_verification`) - The number of executable transactions in the txpool (`txpool_number_of_executable_transactions`) - The time it took to select transactions for inclusion in a block in microseconds (`txpool_select_transactions_time_microseconds`) - The time it took to insert a transaction in the txpool in microseconds (`transaction_insertion_time_in_thread_pool_microseconds`) - [2385](#2385): Added new histogram buckets for some of the TxPool metrics, optimize the way they are collected. - [2347](#2364): Add activity concept in order to protect against infinitely increasing DA gas price scenarios - [2362](#2362): Added a new request_response protocol version `/fuel/req_res/0.0.2`. In comparison with `/fuel/req/0.0.1`, which returns an empty response when a request cannot be fulfilled, this version returns more meaningful error codes. Nodes still support the version `0.0.1` of the protocol to guarantee backward compatibility with fuel-core nodes. Empty responses received from nodes using the old protocol `/fuel/req/0.0.1` are automatically converted into an error `ProtocolV1EmptyResponse` with error code 0, which is also the only error code implemented. More specific error codes will be added in the future. - [2386](#2386): Add a flag to define the maximum number of file descriptors that RocksDB can use. By default it's half of the OS limit. - [2376](#2376): Add a way to fetch transactions in P2P without specifying a peer. - [2361](#2361): Add caches to the sync service to not reask for data it already fetched from the network. - [2327](#2327): Add more services tests and more checks of the pool. Also add an high level documentation for users of the pool and contributors. - [2416](#2416): Define the `GasPriceServiceV1` task. - [2447](#2447): Use new `expiration` policy in the transaction pool. Add a mechanism to prune the transactions when they expired. - [1922](#1922): Added support for posting blocks to the shared sequencer. - [2033](#2033): Remove `Option<BlockHeight>` in favor of `BlockHeightQuery` where applicable. - [2490](#2490): Added pagination support for the `balances` GraphQL query, available only when 'balances indexation' is enabled. - [2439](#2439): Add gas costs for the two new zk opcodes `ecop` and `eadd` and the benches that allow to calibrate them. - [2472](#2472): Added the `amountU128` field to the `Balance` GraphQL schema, providing the total balance as a `U128`. The existing `amount` field clamps any balance exceeding `U64` to `u64::MAX`. - [2526](#2526): Add possibility to not have any cache set for RocksDB. Add an option to either load the RocksDB columns families on creation of the database or when the column is used. - [2532](#2532): Getters for inner rocksdb database handles. - [2524](#2524): Adds a new lock type which is optimized for certain workloads to the txpool and p2p services. - [2535](#2535): Expose `backup` and `restore` APIs on the `CombinedDatabase` struct to create portable backups and restore from them. - [2550](#2550): Add statistics and more limits infos about txpool on the node_info endpoint ### Fixed - [2560](#2560): Fix flaky test by increasing timeout - [2558](#2558): Rename `cost` and `reward` to remove `excess` wording - [2469](#2469): Improved the logic for syncing the gas price database with on_chain database - [2365](#2365): Fixed the error during dry run in the case of race condition. - [2366](#2366): The `importer_gas_price_for_block` metric is properly collected. - [2369](#2369): The `transaction_insertion_time_in_thread_pool_milliseconds` metric is properly collected. - [2413](#2413): block production immediately errors if unable to lock the mutex. - [2389](#2389): Fix construction of reverse iterator in RocksDB. - [2479](#2479): Fix an error on the last iteration of the read and write sequential opcodes on contract storage. - [2478](#2478): Fix proof created by `message_receipts_proof` function by ignoring the receipts from failed transactions to match `message_outbox_root`. - [2485](#2485): Hardcode the timestamp of the genesis block and version of `tai64` to avoid breaking changes for us. - [2511](#2511): Fix backward compatibility of V0Metadata in gas price db. ### Changed - [2469](#2469): Updated adapter for querying costs from DA Block committer API - [2469](#2469): Use the gas price from the latest block to estimate future gas prices - [2501](#2501): Use gas price from block for estimating future gas prices - [2468](#2468): Abstract unrecorded blocks concept for V1 algorithm, create new storage impl. Introduce `TransactionableStorage` trait to allow atomic changes to the storage. - [2295](#2295): `CombinedDb::from_config` now respects `state_rewind_policy` with tmp RocksDB. - [2378](#2378): Use cached hash of the topic instead of calculating it on each publishing gossip message. - [2438](#2438): Refactored service to use new implementation of `StorageRead::read` that takes an offset in input. - [2429](#2429): Introduce custom enum for representing result of running service tasks - [2377](#2377): Add more errors that can be returned as responses when using protocol `/fuel/req_res/0.0.2`. The errors supported are `ProtocolV1EmptyResponse` (status code `0`) for converting empty responses sent via protocol `/fuel/req_res/0.0.1`, `RequestedRangeTooLarge`(status code `1`) if the client requests a range of objects such as sealed block headers or transactions too large, `Timeout` (status code `2`) if the remote peer takes too long to fulfill a request, or `SyncProcessorOutOfCapacity` if the remote peer is fulfilling too many requests concurrently. - [2233](#2233): Introduce a new column `modification_history_v2` for storing the modification history in the historical rocksDB. Keys in this column are stored in big endian order. Changed the behaviour of the historical rocksDB to write changes for new block heights to the new column, and to perform lookup of values from the `modification_history_v2` table first, and then from the `modification_history` table, performing a migration upon access if necessary. - [2383](#2383): The `balance` and `balances` GraphQL query handlers now use index to provide the response in a more performant way. As the index is not created retroactively, the client must be initialized with an empty database and synced from the genesis block to utilize it. Otherwise, the legacy way of retrieving data will be used. - [2463](#2463): The `coinsToSpend` GraphQL query handler now uses index to provide the response in a more performant way. As the index is not created retroactively, the client must be initialized with an empty database and synced from the genesis block to utilize it. Otherwise, the legacy way of retrieving data will be used. - [2556](#2556): Ensure that the `last_recorded_height` is set for the DA gas price source. #### Breaking - [2469](#2469): Move from `GasPriceServicev0` to `GasPriceServiceV1`. Include new config values. - [2438](#2438): The `fuel-core-client` can only work with new version of the `fuel-core`. The `0.40` and all older versions are not supported. - [2438](#2438): Updated `fuel-vm` to `0.59.1` release. Check [release notes](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.59.0) for more details. - [2389](#2258): Updated the `messageProof` GraphQL schema to return a non-nullable `MessageProof`. - [2154](#2154): Transaction graphql endpoints use `TransactionType` instead of `fuel_tx::Transaction`. - [2446](#2446): Use graphiql instead of graphql-playground due to known vulnerability and stale development. - [2379](#2379): Change `kv_store::Value` to be `Arc<[u8]>` instead of `Arc<Vec<u8>>`. - [2490](#2490): Updated GraphQL complexity calculation for `balances` query to account for pagination (`first`/`last`) and nested field complexity (`child_complexity`). Queries with large pagination values or deeply nested fields may have higher complexity costs. - [2463](#2463): 'CoinsQueryError::MaxCoinsReached` variant has been removed. The `InsufficientCoins` variant has been renamed to `InsufficientCoinsForTheMax` and it now contains the additional `max` field - [2463](#2463): The number of excluded ids in the `coinsToSpend` GraphQL query is now limited to the maximum number of inputs allowed in transaction. - [2463](#2463): The `coinsToSpend` GraphQL query may now return different coins, depending whether the indexation is enabled or not. However, regardless of the differences, the returned coins will accurately reflect the current state of the database within the context of the query. - [2526](#2526): By default the cache of RocksDB is now disabled instead of being `1024 * 1024 * 1024`. ## What's Changed * Add metrics to TxPool by @acerone85 in #2321 * Fix collection of gas price metric by @rafal-ch in #2366 * Add documentation to run a ignition node in readme by @AurelienFT in #2363 * Fix collection of tx pool insertion time metric by @rafal-ch in #2369 * Add versioning to request response protocols by @acerone85 in #2362 * Return reason of why proof cant be generated by @rafal-ch in #2258 * p2p: use precalculated topic hash by @yaziciahmet in #2378 * Remove ignore RUSTSEC-2024-0336 by @AurelienFT in #2384 * Deal with negative feed back loop in DA gas price by @MitchTurner in #2364 * Add new flag for maximum file descriptors in rocksdb. by @AurelienFT in #2386 * Add codeowners for gas price algorithm crate by @rafal-ch in #2404 * Weekly `cargo update` by @github-actions in #2373 * chore(gas_price_service): initialize v1 metadata by @rymnc in #2288 * chore(gas_price_service_v0): remove unused trait impl by @rymnc in #2410 * Update tai64 to fix the wrong time offset by @AurelienFT in #2409 * fix(block_producer): immediately return error if lock cannot be acquired during production by @rymnc in #2413 * Add a way to fetch transactions in P2P without specifying a peer by @AurelienFT in #2376 * Add a new code owner for tx pool by @AurelienFT in #2417 * Satisfy clippy in `gas-price-analysis` by @rafal-ch in #2418 * Txpool metrics update by @rafal-ch in #2385 * Improve TxPool tests and documentation by @AurelienFT in #2327 * feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1 by @rymnc in #2416 * Return reason of why proof cant be generated (api change) by @rafal-ch in #2389 * Fuel/Request_Response v0.0.2: More meaningful error messages by @acerone85 in #2377 * Fix reverse iterator in RocksDB by @AurelienFT in #2398 * Add test node herself in reserved nodes. by @AurelienFT in #2390 * Weekly `cargo update` by @github-actions in #2424 * Weekly `cargo update` by @github-actions in #2440 * Resolve some falky tests and improve CI times by @AurelienFT in #2401 * feat: handle `Unknown` transactions, blocks and consensus parameters by @hal3e in #2154 * fix(p2p): cache responses to serve without roundtrip to db by @rymnc in #2352 * Replace task `run()` return result with custom enum by @MitchTurner in #2429 * Fix codeowners by @AurelienFT in #2444 * fix(graphql_playground): use graphiql instead by @rymnc in #2446 * Weekly `cargo update` by @github-actions in #2453 * refactor: remove `Option<BlockHeight>` and use new enum where applicable by @matt-user in #2033 * Fixed the error during dry run by @xgreenx in #2365 * Add decompression traits and a test case by @Dentosal in #2295 * Versioned Storage for Modifications History by @acerone85 in #2233 * Allow DA recorded blocks to come out-of-order by @MitchTurner in #2415 * feat: Change `kv_store::Value` to be Arc<[u8]> instead of Arc<Vec<u8>> by @netrome in #2411 * Optimize balance-related queries with a cache by @rafal-ch in #2383 * fix: Add missing features to `fuel-core-tests` by @netrome in #2467 * Keep data in fails cases in sync service by @AurelienFT in #2361 * Weekly `cargo update` by @github-actions in #2470 * Revert balances amount to `U64` and introduce new `amountU128` getter by @rafal-ch in #2472 * Create uninitialized task for v1 gas price service by @MitchTurner in #2442 * Port the 0.40.2 fix of TAI on master by @AurelienFT in #2485 * Ignore RUSTSEC-2024-0421 by @AurelienFT in #2489 * Ignore receipts from failed transactions in `message_receipts_proof` by @AurelienFT in #2478 * Add unrecorded blocks abstraction to gas price algo by @MitchTurner in #2468 * Fix last iteration in sequential opcode by @AurelienFT in #2479 * fix(gas_price_service_v0): bring back removed fields, causing UB when trying to access by @rymnc in #2511 * Refactor fuel-core to use version of StorageRead::read with offset (Full update to 0.59.1) by @acerone85 in #2438 * Sync the version of the `fuel-core` with minor hot fixes by @xgreenx in #2516 * fix(docs): typo preventing ci checks from passing by @rymnc in #2525 * Integration test for balances and (non)retryable messages by @rafal-ch in #2505 * Add document for launching Ignition node from source and Local network from source by @AurelienFT in #2502 * Make the rocksdb cache optional in config and add policy for column opening by @AurelienFT in #2526 * Weekly `cargo update` by @github-actions in #2530 * chore(rocksdb): getter for inner database handle by @rymnc in #2532 * Use gas prices from actual blocks to calculate estimate gas prices by @MitchTurner in #2501 * chore(codeowners): gas price service codeowners by @rymnc in #2534 * Add zk opcodes by @AurelienFT in #2439 * Gas price simulation data retriever by @acerone85 in #2533 * Shared sequencer integration by @Dentosal in #1922 * Use expiration policy by @AurelienFT in #2447 * Fixed TPS benchmark to work with latest changes by @xgreenx in #2515 * Use indexation cache to satisfy "coins to spend" queries by @rafal-ch in #2463 * feat(txpool|p2p): use seqlock instead of small copy-able RwLocks by @rymnc in #2524 * Create new index for tracking Asset metadata by @maschad in #2445 * feat(rocksdb): remove getters for internal rocksdb handles, expose `backup` instead by @rymnc in #2535 * Integrate with V1 algo for tests by @MitchTurner in #2469 * Lock-free `latest_l2_height` in gas price service by @rafal-ch in #2546 * chore(gas_price_service_v1): strictly ensure last_recorded_height is set, to avoid initial poll of da source by @rymnc in #2556 * Replace old Graphql Gas Price adapter with new latest gas price struct by @MitchTurner in #2547 * Rename cost and rewards without 'excess' by @MitchTurner in #2558 * Add current pool gas to the node info endpoint by @AurelienFT in #2550 * Pagination queries for `balances` endpoint by @rafal-ch in #2490 * 2559 Increase timeout for test by @MitchTurner in #2560 * Add test expiration policy in executor by @AurelienFT in #2563 ## New Contributors * @yaziciahmet made their first contribution in #2378 **Full Changelog**: v0.40.0...v0.41.0

rymnc added 2 commits October 31, 2024 06:02

feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1

6dc5ed7

chore: changelog

b6149d1

rymnc self-assigned this Oct 31, 2024

rymnc added 2 commits October 31, 2024 10:04

test: this test is broken

8a912c4

test: different args

c9d7ed7

rymnc commented Oct 31, 2024

View reviewed changes

rymnc added 5 commits October 31, 2024 16:27

fix: broken test

7a65574

Merge branch 'master' into feat/gas-price-service-v1-impl

d576665

chore: process block size and fees

b4d8855

chore: clean setting of metadata etc

0a358f6

fix: fmt

49a309a

MitchTurner reviewed Nov 10, 2024

View reviewed changes

chore: remove l2 block being sent

c516ea9

MitchTurner reviewed Nov 13, 2024

View reviewed changes

rymnc added 3 commits November 13, 2024 19:14

fix: remove pinning

53291a5

fix: refactor init algo fn

2291207

chore: add test for AlgorithmV1 changes

8ae983f

rymnc marked this pull request as ready for review November 13, 2024 15:09

rymnc requested review from rafal-ch, xgreenx and Dentosal as code owners November 13, 2024 15:09

rymnc requested a review from a team November 13, 2024 15:09

MitchTurner reviewed Nov 14, 2024

View reviewed changes

AurelienFT previously approved these changes Nov 14, 2024

View reviewed changes

chore: new tests for mitch

b2a94d8

rymnc dismissed AurelienFT’s stale review via b2a94d8 November 14, 2024 08:47

MitchTurner previously approved these changes Nov 14, 2024

View reviewed changes

Merge branch 'master' into feat/gas-price-service-v1-impl

db04ae1

rymnc dismissed MitchTurner’s stale review via db04ae1 November 14, 2024 08:49

rymnc requested a review from AurelienFT November 14, 2024 08:49

rymnc requested a review from MitchTurner November 14, 2024 08:49

MitchTurner previously approved these changes Nov 14, 2024

View reviewed changes

AurelienFT previously approved these changes Nov 14, 2024

View reviewed changes

fix spelling

1e3b3f5

AurelienFT dismissed stale reviews from MitchTurner and themself via 1e3b3f5 November 14, 2024 09:09

AurelienFT approved these changes Nov 14, 2024

View reviewed changes

rymnc requested a review from MitchTurner November 14, 2024 10:05

MitchTurner approved these changes Nov 14, 2024

View reviewed changes

rymnc merged commit ba0fa15 into master Nov 14, 2024
38 checks passed

rymnc deleted the feat/gas-price-service-v1-impl branch November 14, 2024 10:23

xgreenx mentioned this pull request Jan 15, 2025

Release v0.41.0 #2565

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1 #2416

feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1 #2416

rymnc commented Oct 31, 2024 •

edited

Loading

rymnc Oct 31, 2024

rymnc Oct 31, 2024

MitchTurner Nov 10, 2024

MitchTurner Nov 10, 2024

MitchTurner Nov 9, 2024

MitchTurner Nov 9, 2024

MitchTurner Nov 10, 2024

MitchTurner Nov 10, 2024

MitchTurner Nov 10, 2024

rymnc Nov 10, 2024

MitchTurner Nov 12, 2024

rymnc Nov 12, 2024

MitchTurner Nov 13, 2024

rymnc Nov 13, 2024

MitchTurner Nov 13, 2024

MitchTurner Nov 13, 2024

rymnc Nov 13, 2024

MitchTurner Nov 13, 2024

rymnc Nov 13, 2024

MitchTurner Nov 14, 2024

MitchTurner Nov 13, 2024 •

edited

Loading

rymnc Nov 13, 2024

MitchTurner Nov 14, 2024

AurelienFT left a comment

	fn drain_l2_block_bytes_for_range(
	&mut self,
	height_range: Range<u32>,
	) -> Result<u128, Error> {
	let mut total: u128 = 0;
	for expected_height in height_range {
	let (actual_height, bytes) = self
	.unrecorded_blocks
	.pop_first()
	.ok_or(Error::L2BlockExpectedNotFound(expected_height))?;
	if actual_height != expected_height {
	return Err(Error::L2BlockExpectedNotFound(expected_height));
	}
	total = total.saturating_add(bytes as u128);
	}
	Ok(total)
	}

feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1 #2416

feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1 #2416

Conversation

rymnc commented Oct 31, 2024 • edited Loading

Linked Issues/PRs

Description

Checklist

Before requesting review

After merging, notify other teams

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MitchTurner Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AurelienFT left a comment

Choose a reason for hiding this comment

rymnc commented Oct 31, 2024 •

edited

Loading

MitchTurner Nov 13, 2024 •

edited

Loading