Add metrics to TxPool #2321

acerone85 · 2024-10-08T20:23:39Z

Linked Issues/PRs

Closes #1937

Description

Number of all transactions in pool
Number of immediately executable transactions in pool
Number of transactions pending verification
(Txs pending verification) how many tasks are created in sync processor
(Txs pending verification) and for how long they were active in the sync processor)
Size of transactions (when transaction is inserted (meaning: it was accepted for inclusion) - histogram)
Time to insert transaction (from when received until it is included in a block)
Select transaction for block (how long it took for the selection algorithm to select transactions)

TODO:

Enable metrics only if config.metrics = true

Checklist

Breaking changes are clearly marked as such in the PR description and changelog
New behavior is reflected in tests
The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

I have reviewed the code myself
I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

Rust SDK
Sway compiler
Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
Someone else?

…_add_more_metrics

…sactions

…_add_more_metrics

Merge remote-tracking branch 'origin/807_add_more_metrics' into 1937_tx_pool_metrics

crates/metrics/src/txpool_metrics.rs

CHANGELOG.md

crates/services/txpool_v2/src/service.rs

rafal-ch · 2024-10-15T09:08:49Z

Looks good overall, left just a few minor comments

MitchTurner · 2024-10-15T08:58:42Z

CHANGELOG.md

@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

 ## [Unreleased]

+### Unchanged


Is Unchanged the right designation here? It looks like we used Added for the other metrics.

yep, this was a mistake of mine (wanted to go to Changed, but I agree that added is better): chanlog updated in dc197d3

yep, Rafa pointed it out too. dc197d3

MitchTurner · 2024-10-15T09:08:28Z

bin/fuel-core/src/cli/run.rs

@@ -562,6 +562,7 @@ impl Command {
                pool_limits,
                heavy_work: pool_heavy_work_config,
                service_channel_limits,
+                metrics: metrics.is_enabled(Module::TxPool),


nit: We should probably rename metrics to disabled_metrics because that's what it is. I think metrics is a misleading name.

done: e3f201d

The way we implemented it in the base PR is that:

we have a metrics config and CLI arg that manages "disabled metrics"

each module still has it's own "metrics: bool", which is initialized on startup by calling metrics_config.is_enabled(MODULE)

This could be confusing at first, but my main motivation was to minimize the changes in all components.

crates/metrics/src/txpool_metrics.rs

MitchTurner · 2024-10-15T09:22:11Z

crates/services/txpool_v2/src/pool.rs

@@ -228,6 +228,16 @@ where
        Ok(can_store_transaction)
    }

+    fn record_transaction_time_in_txpool(tx: &StorageData) {


I don't mind the current flow. You're talking about here?

best_txs .into_iter() .inspect(|storage_data| { if metrics { Self::record_transaction_time_in_txpool(storage_data) } })

It's pretty easy to read.

crates/services/txpool_v2/src/service.rs

…tion

rafal-ch

LGTM 👍

xgreenx · 2024-10-22T18:05:35Z

crates/metrics/src/txpool_metrics.rs

+    pub transaction_time_in_txpool_secs: Histogram,
+    /// Time actively spent by transaction insertion in the thread pool
+    pub transaction_insertion_time_in_thread_pool_milliseconds: Histogram,
+    /// How long it took for the selection algorithm to select transactions
+    pub select_transaction_time_nanoseconds: Histogram,


I think it is better to use the same units to track things. Like either nanoseconds, or milliseconds, or seconds. Not all 3=D

I think Nanoseconds are ok, we always can divide it=)

I'm ok with having different units in the metric producer (I mean: units that fit the value being observed best), as long as the unit is clearly communicated in the metric name. The presentation layer could do all necessary shenanigans required to show proper data.

Otoh, there's also a merit in having a consistent time unit, but nanoseconds everywhere are too fine-grained in my opinion. For example, if transactions can live up to 10 minutes in the TxPool we're gonna be dealing with numbers such as 600_000_000_000.

I'll wait for more opinions before I start fiddling with the code.

I don't have a strong opinion on whether we decide to stick with nanoseconds for all metrics, as @rafal-ch said it has the merit of bringing uniformity across metrics. But even in that case we will need multiple timing buckets for different granularities.

As per the meeting:
transaction_insertion_time_in_thread_pool and select_transaction_time should be measured in microseconds.
10us - minimal value, 5s - max value (however, unlikely)

we don't aim for a single unit for all metrics at the moment.

Changes in 49a79b2

xgreenx · 2024-10-22T18:13:07Z

crates/metrics/src/txpool_metrics.rs

-        let tx_sizes = Vec::new();
+        let tx_size = Histogram::new(buckets(Buckets::TransactionSize));
+        let transaction_time_in_txpool_secs = Histogram::new(buckets(Buckets::Timing));
+        let select_transaction_time_nanoseconds =


I think we need to rename it to be select_transactions_time_nanoseconds

Done in 7c79307

xgreenx · 2024-10-22T18:20:23Z

crates/metrics/src/txpool_metrics.rs

+        let tx_size = Histogram::new(buckets(Buckets::TransactionSize));
+        let transaction_time_in_txpool_secs = Histogram::new(buckets(Buckets::Timing));
+        let select_transaction_time_nanoseconds =
+            Histogram::new(buckets(Buckets::TimingCoarseGrained));


I think these values are too small for selection of transaction and insertion into TxPool. The maximum values. I think we want to have:

50 microseconds
250 microseconds
1 milliseconds
10 milliseconds
100 milliseconds
300 milliseconds (because it is 1/3 of the block execution time)
1 second
5 second

Also you use the same bucket table for nanoseconds and milliseconds

Buckets have been updated in 58bf187 and d46468c

xgreenx · 2024-10-22T18:27:20Z

crates/services/txpool_v2/src/pool.rs

+            fuel_core_metrics::txpool_metrics::txpool_metrics()
+                .transaction_time_in_txpool_secs
+                .observe(elapsed.as_secs_f64());


Sounds like a very bad bucket for TxPool. All transactions will live at least one second. But they can leave up to 10 minutes.

This bucket has been updated in d46468c

xgreenx · 2024-10-22T18:28:29Z

crates/services/txpool_v2/src/pool.rs

+        let start = std::time::Instant::now();
+        let metrics = self.config.metrics;


let start = if self.config.metrics { Some(std::time::Instant::now()) } else { None };

Updated in da77cf9

xgreenx · 2024-10-22T18:29:03Z

crates/services/txpool_v2/src/pool.rs

+        if metrics {
+            Self::record_select_transaction_time_in_nanoseconds(start)
+        };


if let Some(start) = start { Self::record_select_transaction_time_in_nanoseconds(start) }

Updated in da77cf9

xgreenx · 2024-10-22T18:30:23Z

crates/services/txpool_v2/src/pool.rs

            .into_iter()
+            .inspect(|storage_data| {
+                if metrics {


If you move this "If" before best_txs.into_iter() it will be more performant and compiler can do better optimizations

First approach: fec31bb

But I actually ended up with this, trading code clarity for the potential double iteration if metrics are enabled.

xgreenx · 2024-10-22T18:33:07Z

crates/services/txpool_v2/src/service.rs

+        // TODO: move this to the Task struct
+        if self.metrics {
+            let pool = self.pool.read();
+            let num_transactions = pool.storage.tx_count();
+
+            let executable_txs =
+                pool.selection_algorithm.number_of_executable_transactions();
+
+            record_number_of_transactions_in_txpool(num_transactions);
+            record_number_of_executable_transactions_in_txpool(executable_txs);
+        }


It is very bad idea to do it on each iteration of the run. The run function should be as light as possible.

I think we need to update these values when we insert something into TxPool, or when we remove something from TxPool.

Updated in adba071 and 82262eb

Assumptions:

Insertion is only done in pool.insert() within fn insert_transaction() (+ this may also remove some transactions)

All removals are concluded with a call to update_components_and_caches_on_removal()

xgreenx · 2024-10-22T18:34:45Z

crates/services/txpool_v2/src/service.rs

+                txpool_metrics
+                    .number_of_transactions_pending_verification
+                    .inc();


You will increase the number of pending transactions in the queue only when you start to execute this function that doesn't make a lot of sense. We need to increase number of pending transactions before you insert transaction.

Reworked in 959c4b9

@AurelienFT, have a look at this one, please 🙏

xgreenx · 2024-10-22T18:36:48Z

crates/services/txpool_v2/src/storage/mod.rs

+    /// Returns the number of transactions in the storage.
+    fn tx_count(&self) -> usize;


You don't need to expose this finromation. TxPool already has tx_id_to_storage_id that contains this information.

Updated in 7737a14

## Linked Issues/PRs This PR addresses the outstanding comments to the TxPool metrics PR: #2321 ## Description There are a couple of changes to how and when metrics are registered and some histogram buckets are redefined. Additionally there is also a small clean-up of the changelog file. ### Before requesting review - [X] I have reviewed the code myself

@acerone85

## Version v0.41.0 ### Added - [2547](#2547): Replace the old Graphql gas price provider adapter with the ArcGasPriceEstimate. - [2445](#2445): Added GQL endpoint for querying asset details. - [2442](#2442): Add uninitialized task for V1 gas price service - [2154](#2154): Added `Unknown` variant to `ConsensusParameters` graphql queries - [2154](#2154): Added `Unknown` variant to `Block` graphql queries - [2154](#2154): Added `TransactionType` type in `fuel-client` - [2321](#2321): New metrics for the TxPool: - The size of transactions in the txpool (`txpool_tx_size`) - The time spent by a transaction in the txpool in seconds (`txpool_tx_time_in_txpool_seconds`) - The number of transactions in the txpool (`txpool_number_of_transactions`) - The number of transactions pending verification before entering the txpool (`txpool_number_of_transactions_pending_verification`) - The number of executable transactions in the txpool (`txpool_number_of_executable_transactions`) - The time it took to select transactions for inclusion in a block in microseconds (`txpool_select_transactions_time_microseconds`) - The time it took to insert a transaction in the txpool in microseconds (`transaction_insertion_time_in_thread_pool_microseconds`) - [2385](#2385): Added new histogram buckets for some of the TxPool metrics, optimize the way they are collected. - [2347](#2364): Add activity concept in order to protect against infinitely increasing DA gas price scenarios - [2362](#2362): Added a new request_response protocol version `/fuel/req_res/0.0.2`. In comparison with `/fuel/req/0.0.1`, which returns an empty response when a request cannot be fulfilled, this version returns more meaningful error codes. Nodes still support the version `0.0.1` of the protocol to guarantee backward compatibility with fuel-core nodes. Empty responses received from nodes using the old protocol `/fuel/req/0.0.1` are automatically converted into an error `ProtocolV1EmptyResponse` with error code 0, which is also the only error code implemented. More specific error codes will be added in the future. - [2386](#2386): Add a flag to define the maximum number of file descriptors that RocksDB can use. By default it's half of the OS limit. - [2376](#2376): Add a way to fetch transactions in P2P without specifying a peer. - [2361](#2361): Add caches to the sync service to not reask for data it already fetched from the network. - [2327](#2327): Add more services tests and more checks of the pool. Also add an high level documentation for users of the pool and contributors. - [2416](#2416): Define the `GasPriceServiceV1` task. - [2447](#2447): Use new `expiration` policy in the transaction pool. Add a mechanism to prune the transactions when they expired. - [1922](#1922): Added support for posting blocks to the shared sequencer. - [2033](#2033): Remove `Option<BlockHeight>` in favor of `BlockHeightQuery` where applicable. - [2490](#2490): Added pagination support for the `balances` GraphQL query, available only when 'balances indexation' is enabled. - [2439](#2439): Add gas costs for the two new zk opcodes `ecop` and `eadd` and the benches that allow to calibrate them. - [2472](#2472): Added the `amountU128` field to the `Balance` GraphQL schema, providing the total balance as a `U128`. The existing `amount` field clamps any balance exceeding `U64` to `u64::MAX`. - [2526](#2526): Add possibility to not have any cache set for RocksDB. Add an option to either load the RocksDB columns families on creation of the database or when the column is used. - [2532](#2532): Getters for inner rocksdb database handles. - [2524](#2524): Adds a new lock type which is optimized for certain workloads to the txpool and p2p services. - [2535](#2535): Expose `backup` and `restore` APIs on the `CombinedDatabase` struct to create portable backups and restore from them. - [2550](#2550): Add statistics and more limits infos about txpool on the node_info endpoint ### Fixed - [2560](#2560): Fix flaky test by increasing timeout - [2558](#2558): Rename `cost` and `reward` to remove `excess` wording - [2469](#2469): Improved the logic for syncing the gas price database with on_chain database - [2365](#2365): Fixed the error during dry run in the case of race condition. - [2366](#2366): The `importer_gas_price_for_block` metric is properly collected. - [2369](#2369): The `transaction_insertion_time_in_thread_pool_milliseconds` metric is properly collected. - [2413](#2413): block production immediately errors if unable to lock the mutex. - [2389](#2389): Fix construction of reverse iterator in RocksDB. - [2479](#2479): Fix an error on the last iteration of the read and write sequential opcodes on contract storage. - [2478](#2478): Fix proof created by `message_receipts_proof` function by ignoring the receipts from failed transactions to match `message_outbox_root`. - [2485](#2485): Hardcode the timestamp of the genesis block and version of `tai64` to avoid breaking changes for us. - [2511](#2511): Fix backward compatibility of V0Metadata in gas price db. ### Changed - [2469](#2469): Updated adapter for querying costs from DA Block committer API - [2469](#2469): Use the gas price from the latest block to estimate future gas prices - [2501](#2501): Use gas price from block for estimating future gas prices - [2468](#2468): Abstract unrecorded blocks concept for V1 algorithm, create new storage impl. Introduce `TransactionableStorage` trait to allow atomic changes to the storage. - [2295](#2295): `CombinedDb::from_config` now respects `state_rewind_policy` with tmp RocksDB. - [2378](#2378): Use cached hash of the topic instead of calculating it on each publishing gossip message. - [2438](#2438): Refactored service to use new implementation of `StorageRead::read` that takes an offset in input. - [2429](#2429): Introduce custom enum for representing result of running service tasks - [2377](#2377): Add more errors that can be returned as responses when using protocol `/fuel/req_res/0.0.2`. The errors supported are `ProtocolV1EmptyResponse` (status code `0`) for converting empty responses sent via protocol `/fuel/req_res/0.0.1`, `RequestedRangeTooLarge`(status code `1`) if the client requests a range of objects such as sealed block headers or transactions too large, `Timeout` (status code `2`) if the remote peer takes too long to fulfill a request, or `SyncProcessorOutOfCapacity` if the remote peer is fulfilling too many requests concurrently. - [2233](#2233): Introduce a new column `modification_history_v2` for storing the modification history in the historical rocksDB. Keys in this column are stored in big endian order. Changed the behaviour of the historical rocksDB to write changes for new block heights to the new column, and to perform lookup of values from the `modification_history_v2` table first, and then from the `modification_history` table, performing a migration upon access if necessary. - [2383](#2383): The `balance` and `balances` GraphQL query handlers now use index to provide the response in a more performant way. As the index is not created retroactively, the client must be initialized with an empty database and synced from the genesis block to utilize it. Otherwise, the legacy way of retrieving data will be used. - [2463](#2463): The `coinsToSpend` GraphQL query handler now uses index to provide the response in a more performant way. As the index is not created retroactively, the client must be initialized with an empty database and synced from the genesis block to utilize it. Otherwise, the legacy way of retrieving data will be used. - [2556](#2556): Ensure that the `last_recorded_height` is set for the DA gas price source. #### Breaking - [2469](#2469): Move from `GasPriceServicev0` to `GasPriceServiceV1`. Include new config values. - [2438](#2438): The `fuel-core-client` can only work with new version of the `fuel-core`. The `0.40` and all older versions are not supported. - [2438](#2438): Updated `fuel-vm` to `0.59.1` release. Check [release notes](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.59.0) for more details. - [2389](#2258): Updated the `messageProof` GraphQL schema to return a non-nullable `MessageProof`. - [2154](#2154): Transaction graphql endpoints use `TransactionType` instead of `fuel_tx::Transaction`. - [2446](#2446): Use graphiql instead of graphql-playground due to known vulnerability and stale development. - [2379](#2379): Change `kv_store::Value` to be `Arc<[u8]>` instead of `Arc<Vec<u8>>`. - [2490](#2490): Updated GraphQL complexity calculation for `balances` query to account for pagination (`first`/`last`) and nested field complexity (`child_complexity`). Queries with large pagination values or deeply nested fields may have higher complexity costs. - [2463](#2463): 'CoinsQueryError::MaxCoinsReached` variant has been removed. The `InsufficientCoins` variant has been renamed to `InsufficientCoinsForTheMax` and it now contains the additional `max` field - [2463](#2463): The number of excluded ids in the `coinsToSpend` GraphQL query is now limited to the maximum number of inputs allowed in transaction. - [2463](#2463): The `coinsToSpend` GraphQL query may now return different coins, depending whether the indexation is enabled or not. However, regardless of the differences, the returned coins will accurately reflect the current state of the database within the context of the query. - [2526](#2526): By default the cache of RocksDB is now disabled instead of being `1024 * 1024 * 1024`. ## What's Changed * Add metrics to TxPool by @acerone85 in #2321 * Fix collection of gas price metric by @rafal-ch in #2366 * Add documentation to run a ignition node in readme by @AurelienFT in #2363 * Fix collection of tx pool insertion time metric by @rafal-ch in #2369 * Add versioning to request response protocols by @acerone85 in #2362 * Return reason of why proof cant be generated by @rafal-ch in #2258 * p2p: use precalculated topic hash by @yaziciahmet in #2378 * Remove ignore RUSTSEC-2024-0336 by @AurelienFT in #2384 * Deal with negative feed back loop in DA gas price by @MitchTurner in #2364 * Add new flag for maximum file descriptors in rocksdb. by @AurelienFT in #2386 * Add codeowners for gas price algorithm crate by @rafal-ch in #2404 * Weekly `cargo update` by @github-actions in #2373 * chore(gas_price_service): initialize v1 metadata by @rymnc in #2288 * chore(gas_price_service_v0): remove unused trait impl by @rymnc in #2410 * Update tai64 to fix the wrong time offset by @AurelienFT in #2409 * fix(block_producer): immediately return error if lock cannot be acquired during production by @rymnc in #2413 * Add a way to fetch transactions in P2P without specifying a peer by @AurelienFT in #2376 * Add a new code owner for tx pool by @AurelienFT in #2417 * Satisfy clippy in `gas-price-analysis` by @rafal-ch in #2418 * Txpool metrics update by @rafal-ch in #2385 * Improve TxPool tests and documentation by @AurelienFT in #2327 * feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1 by @rymnc in #2416 * Return reason of why proof cant be generated (api change) by @rafal-ch in #2389 * Fuel/Request_Response v0.0.2: More meaningful error messages by @acerone85 in #2377 * Fix reverse iterator in RocksDB by @AurelienFT in #2398 * Add test node herself in reserved nodes. by @AurelienFT in #2390 * Weekly `cargo update` by @github-actions in #2424 * Weekly `cargo update` by @github-actions in #2440 * Resolve some falky tests and improve CI times by @AurelienFT in #2401 * feat: handle `Unknown` transactions, blocks and consensus parameters by @hal3e in #2154 * fix(p2p): cache responses to serve without roundtrip to db by @rymnc in #2352 * Replace task `run()` return result with custom enum by @MitchTurner in #2429 * Fix codeowners by @AurelienFT in #2444 * fix(graphql_playground): use graphiql instead by @rymnc in #2446 * Weekly `cargo update` by @github-actions in #2453 * refactor: remove `Option<BlockHeight>` and use new enum where applicable by @matt-user in #2033 * Fixed the error during dry run by @xgreenx in #2365 * Add decompression traits and a test case by @Dentosal in #2295 * Versioned Storage for Modifications History by @acerone85 in #2233 * Allow DA recorded blocks to come out-of-order by @MitchTurner in #2415 * feat: Change `kv_store::Value` to be Arc<[u8]> instead of Arc<Vec<u8>> by @netrome in #2411 * Optimize balance-related queries with a cache by @rafal-ch in #2383 * fix: Add missing features to `fuel-core-tests` by @netrome in #2467 * Keep data in fails cases in sync service by @AurelienFT in #2361 * Weekly `cargo update` by @github-actions in #2470 * Revert balances amount to `U64` and introduce new `amountU128` getter by @rafal-ch in #2472 * Create uninitialized task for v1 gas price service by @MitchTurner in #2442 * Port the 0.40.2 fix of TAI on master by @AurelienFT in #2485 * Ignore RUSTSEC-2024-0421 by @AurelienFT in #2489 * Ignore receipts from failed transactions in `message_receipts_proof` by @AurelienFT in #2478 * Add unrecorded blocks abstraction to gas price algo by @MitchTurner in #2468 * Fix last iteration in sequential opcode by @AurelienFT in #2479 * fix(gas_price_service_v0): bring back removed fields, causing UB when trying to access by @rymnc in #2511 * Refactor fuel-core to use version of StorageRead::read with offset (Full update to 0.59.1) by @acerone85 in #2438 * Sync the version of the `fuel-core` with minor hot fixes by @xgreenx in #2516 * fix(docs): typo preventing ci checks from passing by @rymnc in #2525 * Integration test for balances and (non)retryable messages by @rafal-ch in #2505 * Add document for launching Ignition node from source and Local network from source by @AurelienFT in #2502 * Make the rocksdb cache optional in config and add policy for column opening by @AurelienFT in #2526 * Weekly `cargo update` by @github-actions in #2530 * chore(rocksdb): getter for inner database handle by @rymnc in #2532 * Use gas prices from actual blocks to calculate estimate gas prices by @MitchTurner in #2501 * chore(codeowners): gas price service codeowners by @rymnc in #2534 * Add zk opcodes by @AurelienFT in #2439 * Gas price simulation data retriever by @acerone85 in #2533 * Shared sequencer integration by @Dentosal in #1922 * Use expiration policy by @AurelienFT in #2447 * Fixed TPS benchmark to work with latest changes by @xgreenx in #2515 * Use indexation cache to satisfy "coins to spend" queries by @rafal-ch in #2463 * feat(txpool|p2p): use seqlock instead of small copy-able RwLocks by @rymnc in #2524 * Create new index for tracking Asset metadata by @maschad in #2445 * feat(rocksdb): remove getters for internal rocksdb handles, expose `backup` instead by @rymnc in #2535 * Integrate with V1 algo for tests by @MitchTurner in #2469 * Lock-free `latest_l2_height` in gas price service by @rafal-ch in #2546 * chore(gas_price_service_v1): strictly ensure last_recorded_height is set, to avoid initial poll of da source by @rymnc in #2556 * Replace old Graphql Gas Price adapter with new latest gas price struct by @MitchTurner in #2547 * Rename cost and rewards without 'excess' by @MitchTurner in #2558 * Add current pool gas to the node info endpoint by @AurelienFT in #2550 * Pagination queries for `balances` endpoint by @rafal-ch in #2490 * 2559 Increase timeout for test by @MitchTurner in #2560 * Add test expiration policy in executor by @AurelienFT in #2563 ## New Contributors * @yaziciahmet made their first contribution in #2378 **Full Changelog**: v0.40.0...v0.41.0

rafal-ch and others added 30 commits October 7, 2024 13:01

Add gas_per_block metric

eb5525c

Add transactions_per_block metric

260b745

Add fee_per_block metric

c84204b

Correct bucket names

8c5a979

Producer metrics - gas price

ddb424e

Update bucket values for new metrics

27fb0fd

chore: add libp2p bandwidth metrics

09357db

fix: use dns

088b918

chore: more p2p metrics

76b1084

Rework histogram bucket initialization

090ada8

Bucket access function returns iterator

bd8b64b

Extract the buckets module

f205434

Update changelog

de98ec5

Merge remote-tracking branch 'upstream/master' into 807_add_more_metrics

58cf08b

Fix tokio dependencies

c897f8a

Add test for the presence of all required buckets

f184a61

Additional length assert in bucket tests

b86efce

Remove the GasPrice metric

b8241a0

Fix strum dependency definition

94f3d42

Update the metric bucket values

4166809

Use explicit _gwei suffix for "fee_per_block" metric

3b128b5

Update changelog

8817d1a

Merge branch 'master' into 807_add_more_metrics

9bc707c

Reformat Buckets::Timing for clarity

3badebd

Merge remote-tracking branch 'upstream/807_add_more_metrics' into 807…

aadc59f

…_add_more_metrics

Calculate total_gas_used and total_fee in a single pass over tran…

87eed6d

…sactions

Move metrics to executor

fa60c9e

Add the executor_size_per_block_bytes metric

10e3407

Remove no longer used metrics from the importer

0978160

Remove the no longer needed total_fee() function

3920e74

rafal-ch and others added 6 commits October 14, 2024 21:06

Merge remote-tracking branch 'upstream/807_add_more_metrics' into 807…

395f491

…_add_more_metrics

Log metrics config at startup

eb3872f

Allow creating metrics config from empty string, it's equal to all

bee9c6f

Merge remote-tracking branch 'upstream/master' into 807_add_more_metrics

8da222a

Merge

5da05f0

Merge remote-tracking branch 'origin/807_add_more_metrics' into 1937_tx_pool_metrics

CHANGELOG

7b3e465

Base automatically changed from 807_add_more_metrics to master October 14, 2024 22:24

acerone85 added 2 commits October 15, 2024 08:46

Merge branch 'master' into 1937_tx_pool_metrics

d1f94b7

Organize metrics recording functions

e92c30f

rafal-ch reviewed Oct 15, 2024

View reviewed changes

crates/metrics/src/txpool_metrics.rs Outdated Show resolved Hide resolved

acerone85 changed the title ~~WIP: Add metrics to TxPool~~ Add metrics to TxPool Oct 15, 2024

rafal-ch reviewed Oct 15, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

acerone85 added 2 commits October 15, 2024 10:06

Add coarse grained timing buckets for histograms in ms and ns

365807b

Update changelog

dc197d3

rafal-ch reviewed Oct 15, 2024

View reviewed changes

crates/services/txpool_v2/src/service.rs Outdated Show resolved Hide resolved

Rename op_without_metrics to op

1e3810d

MitchTurner reviewed Oct 15, 2024

View reviewed changes

acerone85 added 3 commits October 15, 2024 10:33

Better naming for insert transaction internal operation

889b92d

Rename metrics into disable metrics in CLI extract configuration func…

e3f201d

…tion

Add documentation for TxPool metrics

9cee869

MitchTurner approved these changes Oct 15, 2024

View reviewed changes

rafal-ch approved these changes Oct 15, 2024

View reviewed changes

acerone85 merged commit 9c28199 into master Oct 15, 2024
38 checks passed

acerone85 deleted the 1937_tx_pool_metrics branch October 15, 2024 11:23

xgreenx reviewed Oct 22, 2024

View reviewed changes

rafal-ch mentioned this pull request Oct 23, 2024

Txpool metrics update #2385

Merged

1 task

xgreenx mentioned this pull request Jan 15, 2025

Release v0.41.0 #2565

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add metrics to TxPool #2321

Add metrics to TxPool #2321

acerone85 commented Oct 8, 2024 •

edited by rafal-ch

Loading

rafal-ch commented Oct 15, 2024

MitchTurner Oct 15, 2024

acerone85 Oct 15, 2024

acerone85 Oct 15, 2024

MitchTurner Oct 15, 2024

acerone85 Oct 15, 2024

rafal-ch Oct 15, 2024 •

edited

Loading

MitchTurner Oct 15, 2024

rafal-ch left a comment

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

acerone85 Oct 23, 2024

rafal-ch Oct 23, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

xgreenx Oct 22, 2024

rafal-ch Oct 23, 2024

		@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

		## [Unreleased]

		### Unchanged

		let start = std::time::Instant::now();
		let metrics = self.config.metrics;

		/// Returns the number of transactions in the storage.
		fn tx_count(&self) -> usize;

Add metrics to TxPool #2321

Add metrics to TxPool #2321

Conversation

acerone85 commented Oct 8, 2024 • edited by rafal-ch Loading

Linked Issues/PRs

Description

Checklist

Before requesting review

After merging, notify other teams

rafal-ch commented Oct 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafal-ch Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafal-ch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acerone85 commented Oct 8, 2024 •

edited by rafal-ch

Loading

rafal-ch Oct 15, 2024 •

edited

Loading