Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config variable for portable settings store #868

Closed

Conversation

rddim
Copy link
Contributor

@rddim rddim commented Dec 12, 2020


Added config variable for portable settings store

Important note
Backup your settings from %AppData%\Roaming\FreeTube

Pull Request Type

  • Bugfix
  • Feature Implementation

Related issue
Fixes #130 Fixes #746

Description
This PR add a config variable FREETUBE_APPDATA_DIR for portable settings store in a custom folder.

Testing (for code that is not small enough to be easily understandable)

  1. Backup your settings from %AppData%\Roaming\FreeTube and rename/remove the FreeTube folder
  2. Windows users should use the zipped portable version, not the portable exe
  3. In the folder where the FreeTube.exe lives:
    • create a shortcut and add %comspec% /c set FREETUBE_APPDATA_DIR=%CD%\Data&& FreeTube.exe to the Target field.
      OR
    • create a batch file containing:
set FREETUBE_APPDATA_DIR=%CD%\Data
FreeTube.exe
  1. Run the shortcut or the batch file. In both case the cmd.exe will be running (don't close it) and the Data folder will be created in the same folder as FreeTube.exe

Any ramifications remaining

  1. The empty folder %AppData%\Roaming\FreeTube\Dictionaries is created
  2. The registry key for the browser extension is added to HKCU\Software\Classes\freetube

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 7 (build 7601.0)
  • FreeTube version: 0.9.3 nightly

Additional context

  1. The code is taken from https://github.com/getferdi/ferdi/blob/develop/src/index.js#L13:L23
  2. The issues with the empty folder and the registry key can be solved with the portable launcher

@rddim rddim marked this pull request as draft December 12, 2020 22:09
@MichiFr
Copy link

MichiFr commented Apr 18, 2021

Maybe I missed the obvious, however, this does not work. I've chosen the batch file version and create a .cmd file with those given two line. The shortcut variant did not work on my side for whatever reason. My portable FreeTube is located on a network share, btw.

FreeTube starts and creates a new subfolder within APPDATA and a bunch of files in it - not just the subfolder Dictionaries as mentioned above. On that Windows 10 machine, FreeTube portable (from ZIP-File) was execute for the first time.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Sep 17, 2021

@rddim Please update us otherwise close this request.

@rddim
Copy link
Contributor Author

rddim commented Sep 20, 2021

@MichiFr
It was working, but you must compile for yourself

@efb4f5ff-1298-471a-8973-3d47447115dc
I will close this PR because for 9 months there is no interests from the main develepors and I don't have a motivation for updates. The code is here, so anyone can use it for good.

@rddim rddim closed this Sep 20, 2021
@efb4f5ff-1298-471a-8973-3d47447115dc

@rddim i think i got it wrong there. There is definitely interest in your PR but it was a draft so the assumption was made that it wasn't a finished PR. Normally we start looking at a PR when its not a draft anymore. We would like u to work on this further if it interests u.

@rddim
Copy link
Contributor Author

rddim commented Sep 20, 2021

#746 (comment) and I create a draft... and waiting months for any comment. Also I don't have enough skills to maintain this part of the code in the future. As I said: the code is here, if someone have a motivation and interests I will be very happy to see this released (waiting from version 0.12). Thanks for the chance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store data and settings in portable directory with portable version Request: Portable Version (Windows)
3 participants