Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store portable apps settings in same directory as the EXE #4765

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Mar 14, 2024

Store portable apps settings in same directory as the EXE

Pull Request Type

  • Bugfix

Related issue

Thanks @rddim for the initial PR #868

Description

This PR should fix the issue with the portable exe storing the data in AppData (thus not making it very portable)

Testing

  • Build the App on windows
  • run the exe file (not setup.exe)
  • notice local directory is made
  • change settings notice that settings.db file is updated

Build should be available here: https://github.com/ChunkyProgrammer/FreeTube/actions/runs/8283749172/job/22667673906

Desktop

  • OS: Linux Mint
  • OS Version: 21.3
  • FreeTube version: 0.19.1 (nightly)

Additional context

I coded this on Linux but did some testing on Windows

Co-Authored-By: Rusi Dimitrov <rddim@users.noreply.github.com>
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 14, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 14, 2024 15:50
auto-merge was automatically disabled March 14, 2024 16:25

Pull request was closed

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 14, 2024
@ChunkyProgrammer ChunkyProgrammer deleted the try-on-windows-machine branch October 8, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant